Add typing annotations

Author: ale-rt

.meta.toml

@@ -9,6 +9,15 @@ commit-id = "2.9.0"
 codespell_extra_lines = """
         exclude: docs/locale/.*.pot
 """
+extra_lines = """
+-   repo: https://github.com/pre-commit/mirrors-mypy
+    rev: v1.18.2
+    hooks:
+    -   id: mypy
+        additional_dependencies:
+            - types-decorator
+        exclude: docs
+"""
 
 [pyproject]
 check_manifest_ignores = """
@@ -23,7 +32,7 @@ check_manifest_ignores = """
     "requirements-docs.txt",
     "requirements.txt",
 """
-dependencies_ignores = "['Products.PrintingMailHost', 'plone.app.iterate',]"
+dependencies_ignores = "['Products.DCWorkflow', 'Products.PrintingMailHost', 'plone.app.iterate',]"
 codespell_ignores = "manuel,checkin"
 
 [tox]

.pre-commit-config.yaml

@@ -85,6 +85,13 @@ repos:
 #  """
 ##
 
+-   repo: https://github.com/pre-commit/mirrors-mypy
+    rev: v1.18.2
+    hooks:
+    -   id: mypy
+        additional_dependencies:
+            - types-decorator
+        exclude: docs
 
 ##
 # Add extra configuration options in .meta.toml:

news/+a04874c0.internal.md

@@ -0,0 +1 @@
+Add typing annotations [@ale-rt]

pyproject.toml

@@ -124,7 +124,7 @@ Zope = [
 ]
 python-dateutil = ['dateutil']
 pytest-plone = ['pytest', 'zope.pytestlayer', 'plone.testing', 'plone.app.testing']
-ignore-packages = ['Products.PrintingMailHost', 'plone.app.iterate',]
+ignore-packages = ['Products.DCWorkflow', 'Products.PrintingMailHost', 'plone.app.iterate',]
 
 ##
 # Add extra configuration options in .meta.toml:

setup.py

@@ -36,6 +36,7 @@
         "plone.dexterity",
         "plone.i18n",
         "plone.registry",
+        "plone.supermodel",
         "plone.uuid",
         "zope.globalrequest",
         "Products.CMFCore",

src/plone/api/addon.py

@@ -11,6 +11,7 @@
 from plone.base.utils import get_installer
 from Products.CMFPlone.controlpanel.browser.quickinstaller import InstallerView
 from Products.GenericSetup import EXTENSION
+from typing import Any
 from zope.component import getAllUtilitiesRegisteredFor
 from zope.globalrequest import getRequest
 
@@ -94,7 +95,7 @@ def _get_non_installable_addons() -> NonInstallableAddons:
 
 
 @lru_cache(maxsize=1)
-def _cached_addons() -> tuple[tuple[str, AddonInformation]]:
+def _cached_addons() -> tuple[tuple[str, AddonInformation], ...]:
     """Return information about add-ons in this installation.
 
     :returns: Tuple of tuples with add-on id and AddonInformation.
@@ -130,7 +131,7 @@ def _cached_addons() -> tuple[tuple[str, AddonInformation]]:
         profile_type = pid_parts[-1]
         if product_id not in addons:
             # get some basic information on the product
-            product = {
+            product: dict[str, Any] = {
                 "id": product_id,
                 "version": get_version(product_id),
                 "title": product_id,
@@ -271,10 +272,10 @@ def get(addon: str) -> AddonInformation:
     :returns: Add-on information.
     :rtype: string
     """
-    addons = dict(_cached_addons())
+    addons: dict[str, AddonInformation] = dict(_cached_addons())
     if addon not in addons:
         raise InvalidParameterError(f"No add-on {addon} found.")
-    return _update_addon_info(addons.get(addon), _get_installer())
+    return _update_addon_info(addons[addon], _get_installer())
 
 
 @required_parameters("addon")