diff --git a/docs/README.rst b/docs/README.rst index 2ec49ca..ca9ba18 100644 --- a/docs/README.rst +++ b/docs/README.rst @@ -1164,7 +1164,7 @@ has been applied. Some of the more common such tests are shown below. To verify that a product has been installed (e.g. as a dependency via ``metadata.xml``):: - from Products.CMFPlone.utils import get_installer + from plone.base.utils import get_installer qi = get_installer(portal) self.assertTrue(qi.is_product_installed('my.product')) diff --git a/news/+8571c2ca.bugfix.rst b/news/+8571c2ca.bugfix.rst new file mode 100644 index 0000000..74a65dd --- /dev/null +++ b/news/+8571c2ca.bugfix.rst @@ -0,0 +1,3 @@ +Use ``plone.base.utils`` instead of ``Products.CMFPlone.utils`` when deprecated. +No longer pass deprecated ``setup_content=False`` to ``addPloneSite`` call. +[maurits] diff --git a/setup.py b/setup.py index a7a06df..ac124fd 100644 --- a/setup.py +++ b/setup.py @@ -70,6 +70,7 @@ "Zope", "persistent", "plone.app.contenttypes", + "plone.base", "plone.dexterity", "plone.memoize", "plone.registry", diff --git a/src/plone/app/testing/bbb.py b/src/plone/app/testing/bbb.py index f36f8c8..109ab86 100644 --- a/src/plone/app/testing/bbb.py +++ b/src/plone/app/testing/bbb.py @@ -2,8 +2,8 @@ from AccessControl import getSecurityManager from plone.app import testing +from plone.base.utils import unrestricted_construct_instance from plone.testing import zope -from Products.CMFPlone.utils import _createObjectByType from Testing.ZopeTestCase.functional import Functional import transaction @@ -14,7 +14,7 @@ def _createMemberarea(portal, user_id): mtool = portal.portal_membership members = mtool.getMembersFolder() if members is None: - _createObjectByType("Folder", portal, id="Members") + unrestricted_construct_instance("Folder", portal, id="Members") if not mtool.getMemberareaCreationFlag(): mtool.setMemberareaCreationFlag() mtool.createMemberArea(user_id) diff --git a/src/plone/app/testing/helpers.py b/src/plone/app/testing/helpers.py index 6fd50a7..887cde5 100644 --- a/src/plone/app/testing/helpers.py +++ b/src/plone/app/testing/helpers.py @@ -79,7 +79,7 @@ def quickInstallProduct(portal, productName, reinstall=False): zope.login(app["acl_users"], SITE_OWNER_NAME) - from Products.CMFPlone.utils import get_installer + from plone.base.utils import get_installer qi = get_installer(portal) diff --git a/src/plone/app/testing/helpers.rst b/src/plone/app/testing/helpers.rst index 8a6d65b..d994ef2 100644 --- a/src/plone/app/testing/helpers.rst +++ b/src/plone/app/testing/helpers.rst @@ -50,7 +50,7 @@ course, if our setup had changed any other global or external state, we would need to tear that down as well. >>> def is_installed(portal, product_name): - ... from Products.CMFPlone.utils import get_installer + ... from plone.base.utils import get_installer ... qi = get_installer(portal) ... return qi.is_product_installed(product_name) diff --git a/src/plone/app/testing/layers.py b/src/plone/app/testing/layers.py index 0489529..d61ff0f 100644 --- a/src/plone/app/testing/layers.py +++ b/src/plone/app/testing/layers.py @@ -210,7 +210,6 @@ def setUpDefaultContent(self, app): app, PLONE_SITE_ID, title=PLONE_SITE_TITLE, - setup_content=False, default_language=DEFAULT_LANGUAGE, extension_ids=self.extensionProfiles, )