Skip to content

Commit 32f85e5

Browse files
Missed a few patches for scale storage unique id.
1 parent ef72d00 commit 32f85e5

2 files changed

Lines changed: 9 additions & 6 deletions

File tree

src/plone/restapi/tests/test_documentation.py

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
from base64 import b64encode
22
from datetime import datetime
3-
from unittest.mock import patch
43
from pkg_resources import resource_filename
54
from plone import api
65
from plone.app.discussion.interfaces import IConversation
@@ -25,6 +24,7 @@
2524
from plone.restapi.testing import PLONE_RESTAPI_ITERATE_FUNCTIONAL_TESTING
2625
from plone.restapi.testing import register_static_uuid_utility
2726
from plone.restapi.testing import RelativeSession
27+
from plone.restapi.tests.helpers import patch_scale_uuid
2828
from plone.restapi.tests.statictime import StaticTime
2929
from plone.scale import storage
3030
from plone.testing.z2 import Browser
@@ -301,7 +301,8 @@ def test_documentation_news_item(self):
301301
self.portal.newsitem.image_caption = "This is an image caption."
302302
transaction.commit()
303303

304-
with patch.object(storage, "uuid4", return_value="uuid1"):
304+
scale_url_uuid = "uuid1"
305+
with patch_scale_uuid(scale_url_uuid):
305306
response = self.api_session.get(self.portal.newsitem.absolute_url())
306307
save_request_and_response_for_docs("newsitem", response)
307308

@@ -349,7 +350,8 @@ def test_documentation_image(self):
349350
data=image_data, contentType="image/png", filename="image.png"
350351
)
351352
transaction.commit()
352-
with patch.object(storage, "uuid4", return_value="uuid1"):
353+
scale_url_uuid = "uuid1"
354+
with patch_scale_uuid(scale_url_uuid):
353355
response = self.api_session.get(self.portal.image.absolute_url())
354356
save_request_and_response_for_docs("image", response)
355357

src/plone/restapi/tests/test_services.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
from unittest.mock import patch
21
from plone.app.testing import setRoles
32
from plone.app.testing import SITE_OWNER_NAME
43
from plone.app.testing import SITE_OWNER_PASSWORD
@@ -8,6 +7,7 @@
87
from plone.namedfile.file import NamedBlobImage
98
from plone.restapi.testing import PLONE_RESTAPI_DX_FUNCTIONAL_TESTING
109
from plone.restapi.testing import RelativeSession
10+
from plone.restapi.tests.helpers import patch_scale_uuid
1111
from plone.scale import storage
1212
from z3c.relationfield import RelationValue
1313
from zope.component import getUtility
@@ -87,7 +87,8 @@ def test_get_news_item(self):
8787
self.portal.news1.image_caption = "This is an image caption."
8888
transaction.commit()
8989

90-
with patch.object(storage, "uuid4", return_value="uuid1"):
90+
scale_url_uuid = "uuid1"
91+
with patch_scale_uuid(scale_url_uuid):
9192
response = self.api_session.get(self.portal.news1.absolute_url())
9293

9394
self.assertEqual(response.status_code, 200)
@@ -112,7 +113,7 @@ def test_get_news_item(self):
112113
"This is an image caption.", response.json()["image_caption"]
113114
)
114115
self.assertDictContainsSubset(
115-
{"download": self.portal_url + "/news1/@@images/uuid1.png"}, # noqa
116+
{"download": self.portal_url + f"/news1/@@images/{scale_url_uuid}.png"},
116117
response.json()["image"],
117118
)
118119

0 commit comments

Comments
 (0)