Merge branch 'master' into andrew/issue-383-fix-hang

Author: ayjayt

.gitignore

@@ -23,3 +23,5 @@ src/py/integration_tests/report*
 # avoid ignore .gitkeep
 !src/py/integration_tests/renders/.gitkeep
 node_modules/
+
+src/py/site/*

src/py/CHANGELOG.txt

@@ -1,3 +1,4 @@
+- Fix bug where attribute was inconsistently named
 v1.1.0rc0
 - Improve verbosity of errors when starting kaleido improperly
 - Add new api functions start/stop_sync_server

src/py/kaleido/kaleido.py

@@ -56,8 +56,8 @@ class Kaleido(choreo.Browser):
 
     async def close(self):
         """Close the browser."""
-        if self.tmp_dir:
-            self.tmp_dir.clean()
+        if self._tmp_dir:
+            self._tmp_dir.clean()
         _logger.info("Cancelling tasks.")
         for task in self._main_tasks:
             if not task.done():
@@ -138,8 +138,8 @@ def __init__(self, *args, **kwargs):  # noqa: D417 no args/kwargs in description
         elif page and hasattr(page, "is_file") and page.is_file():
             self._index = page.as_uri()
         else:
-            self.tmp_dir = TmpDirectory(sneak=self.is_isolated())
-            index = self.tmp_dir.path / "index.html"
+            self._tmp_dir = TmpDirectory(sneak=self.is_isolated())
+            index = self._tmp_dir.path / "index.html"
             self._index = index.as_uri()
             if not page:
                 page = PageGenerator(plotly=self._plotlyjs, mathjax=self._mathjax)