Cause kaleido to explicitly fail if no chromium: (#224)

ayjayt · web-flow · commit 6abcd029e2c2 · 2024-11-18T08:56:51.000-05:00
Before we were letting choreographer handle it.
diff --git a/src/py/kaleido/scopes/plotly.py b/src/py/kaleido/scopes/plotly.py
@@ -59,6 +59,8 @@ def __init__(self, plotlyjs=None, mathjax=None, topojson=None, mapbox_access_tok
             'kaleido_scopes.js'
             )
         path = os.environ.get("BROWSER_PATH", which_browser())
+        if not path:
+            raise RuntimeError("Kaleido now requires that chrome/chromium is installed separately. Kaleido will try to detect it automatically, but the environmental error \"BROWSER_PATH\" can also be set")
         if tmp_path:
             temp_args = dict(dir=self.tmp_path)
         elif "snap" in path:

Original file line number	Diff line number	Diff line change
`@@ -59,6 +59,8 @@ def __init__(self, plotlyjs=None, mathjax=None, topojson=None, mapbox_access_tok`
`59`	`59`	`'kaleido_scopes.js'`
`60`	`60`	`)`
`61`	`61`	`path = os.environ.get("BROWSER_PATH", which_browser())`
	`62`	`+ if not path:`
	`63`	`+ raise RuntimeError("Kaleido now requires that chrome/chromium is installed separately. Kaleido will try to detect it automatically, but the environmental error \"BROWSER_PATH\" can also be set")`
`62`	`64`	`if tmp_path:`
`63`	`65`	`temp_args = dict(dir=self.tmp_path)`
`64`	`66`	`elif "snap" in path:`