Fix bad access and typing errors:

Some of these may have been legit errors found by pyright, some of it
is just pyright not accepting certain patterns.

Author: ayjayt

src/py/kaleido/_utils/__init__.py

@@ -12,7 +12,7 @@
 _logger = logistro.getLogger(__name__)
 
 if TYPE_CHECKING:
-    from typing import Any, Callable, Coroutine
+    from typing import Any, AsyncIterator, Callable, Coroutine
 
 
 def event_printer(name: str) -> Callable[[Any], Coroutine[Any, Any, None]]:
@@ -39,7 +39,7 @@ def create_task_log_error(coroutine) -> asyncio.Task:
     return t
 
 
-def ensure_async_iter(obj):
+def ensure_async_iter(obj) -> AsyncIterator[Any]:
     """Convert any iterable to an async iterator."""
     if hasattr(obj, "__aiter__"):
         return obj

src/py/kaleido/kaleido.py

@@ -195,7 +195,7 @@ async def open(self):
         del self._saved_page_arg
 
         if isinstance(page, (Path, str)):
-            if (_p := _utils.get_path(page)).is_file():
+            if (_p := path_tools.get_path(page)).is_file():
                 self._index = _p.as_uri()
             else:
                 raise FileNotFoundError(f"{page!s} does not exist.")
@@ -333,6 +333,8 @@ async def _render_task(
                 spec["format"],  # should just take spec
             )
             full_path.touch()  # claim our name
+        else:
+            full_path = None
 
         tab = await self._get_kaleido_tab()
 
@@ -354,7 +356,7 @@ async def _render_task(
                 ),
                 self._timeout,
             )
-            if _write:
+            if _write and full_path:
                 render_prof.profile_log.tick("starting file write")
                 await _utils.to_thread(full_path.write_bytes, img_bytes)
                 render_prof.profile_log.tick("file write done")
@@ -363,7 +365,7 @@ async def _render_task(
                 return img_bytes
         except BaseException as e:
             render_prof.profile_log.tick("errored out")
-            if _write:
+            if _write and full_path:
                 full_path.unlink()  # failure, no write
             render_prof.error = e
             raise
@@ -518,15 +520,15 @@ async def calc_fig(
                 stacklevel=2,
             )
 
-        async def _temp_generator():
-            yield {
+        spec: FigureDict = {
                 "fig": fig,
                 "opts": opts,
                 "topojson": topojson,
             }
-
-        return await self.write_fig_from_object(
-            fig_dicts=_temp_generator(),
+        # pyright > mypy, but:
+        # pyright doesn't understand literals in overloads as well
+        return await self.write_fig_from_object( # type: ignore[reportCallIssue]
+            fig_dicts=spec,
             cancel_on_error=True,
             _write=False,
             stepper=stepper,