Skip to content

Andrew/fix/352#354

Merged
ayjayt merged 6 commits into
masterfrom
andrew/fix/352
Aug 18, 2025
Merged

Andrew/fix/352#354
ayjayt merged 6 commits into
masterfrom
andrew/fix/352

Conversation

@ayjayt
Copy link
Copy Markdown
Collaborator

@ayjayt ayjayt commented Jul 10, 2025

Closes #352

@ayjayt ayjayt requested a review from LiamConnors July 10, 2025 20:00
@ayjayt
Copy link
Copy Markdown
Collaborator Author

ayjayt commented Jul 10, 2025

@LiamConnors i'm going to add tests for this based off your example as well

@gvwilson gvwilson requested a review from emilykl July 11, 2025 17:24
@gvwilson gvwilson added feature something new P1 needs immediate attention labels Jul 11, 2025
@emilykl
Copy link
Copy Markdown
Collaborator

emilykl commented Jul 15, 2025

@ayjayt The fix in src/py/kaleido/kaleido.py looks fine but not sure why all the extraneous HTML and CSS changes are part of this PR, could you clarify?

@ayjayt
Copy link
Copy Markdown
Collaborator Author

ayjayt commented Jul 15, 2025

Generated html Docs for api reference.

@LiamConnors

This comment was marked as resolved.

@ayjayt

This comment was marked as resolved.

@LiamConnors

This comment was marked as resolved.

@ayjayt

This comment was marked as resolved.

@ayjayt
Copy link
Copy Markdown
Collaborator Author

ayjayt commented Aug 11, 2025

@emilykl

  1. Liam and I got off topic so I created another issue
  2. This PR fixes a naming error

Comment thread .gitignore
!src/py/integration_tests/renders/.gitkeep
node_modules/

src/py/site/*
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this directory really need to be in the gitignore? Is it generated by some automated process in the repo? (nitpick)

Copy link
Copy Markdown
Collaborator

@emilykl emilykl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@ayjayt ayjayt merged commit 0668e4d into master Aug 18, 2025
4 checks passed
@ayjayt ayjayt deleted the andrew/fix/352 branch August 18, 2025 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature something new P1 needs immediate attention

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AttributeError: 'Kaleido' object has no attribute 'tmp_dir'. Did you mean: '_tmp_dir'?

4 participants