Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -23,3 +23,5 @@ src/py/integration_tests/report*
# avoid ignore .gitkeep
!src/py/integration_tests/renders/.gitkeep
node_modules/

src/py/site/*
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this directory really need to be in the gitignore? Is it generated by some automated process in the repo? (nitpick)

1 change: 1 addition & 0 deletions src/py/CHANGELOG.txt
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
- Fix bug where attribute was inconsistently named
v1.1.0rc0
- Improve verbosity of errors when starting kaleido improperly
- Add new api functions start/stop_sync_server
Expand Down
8 changes: 4 additions & 4 deletions src/py/kaleido/kaleido.py
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,8 @@ class Kaleido(choreo.Browser):

async def close(self):
"""Close the browser."""
if self.tmp_dir:
self.tmp_dir.clean()
if self._tmp_dir:
self._tmp_dir.clean()
_logger.info("Cancelling tasks.")
for task in self._main_tasks:
if not task.done():
Expand Down Expand Up @@ -138,8 +138,8 @@ def __init__(self, *args, **kwargs): # noqa: D417 no args/kwargs in description
elif page and hasattr(page, "is_file") and page.is_file():
self._index = page.as_uri()
else:
self.tmp_dir = TmpDirectory(sneak=self.is_isolated())
index = self.tmp_dir.path / "index.html"
self._tmp_dir = TmpDirectory(sneak=self.is_isolated())
index = self._tmp_dir.path / "index.html"
self._index = index.as_uri()
if not page:
page = PageGenerator(plotly=self._plotlyjs, mathjax=self._mathjax)
Expand Down
323 changes: 0 additions & 323 deletions src/py/site/404.html

This file was deleted.

Loading
Loading