Andrew/api factor#370
Merged
Merged
Conversation
Collaborator
Author
|
emilykl
reviewed
Jul 30, 2025
emilykl
reviewed
Jul 30, 2025
emilykl
reviewed
Jul 30, 2025
| else: | ||
| full_path = path | ||
| if not full_path.parent.is_dir(): | ||
| raise RuntimeError( |
Collaborator
There was a problem hiding this comment.
Under what circumstances would this RuntimeError be reached?
(not directly relevant to this PR, just curious)
Collaborator
Author
There was a problem hiding this comment.
/path/to/my/new_file.jpg <-- will show up in the else. But we expect they've created everything up until new_file.jpg, we'll create that though.
emilykl
reviewed
Jul 30, 2025
| @@ -1,3 +1,4 @@ | |||
| - Add not-released api functions start/stop_sync_server | |||
Collaborator
There was a problem hiding this comment.
not-released
I mean... everything added in a PR is not-released, until we release it. 🙃
Collaborator
Author
There was a problem hiding this comment.
yeah, i think i meant not-documented
emilykl
reviewed
Jul 30, 2025
Comment on lines
+41
to
+42
| "start_kaleido_sync_server", | ||
| "stop_kaleido_sync_server", |
Collaborator
There was a problem hiding this comment.
Suggested change
| "start_kaleido_sync_server", | |
| "stop_kaleido_sync_server", | |
| "start_sync_server", | |
| "stop_sync_server", |
Collaborator
Author
There was a problem hiding this comment.
is my ruff broken? i feel like thats a ruff catch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
kaleido.start_sync_server()andkaleido.stop_sync_server()to start and stop global Kaleido serverkaleido.calc_fig_sync(),kaleido.write_fig_sync(), andkaleido.write_fig_from_object_sync()to use the global server if runningThe principal change here is in:
src/py/kaleido/_sync_server.py
However there was type work done and some error messages improved elsewhere to silence the type checker.