Andrew/test utils#398
Merged
Merged
Conversation
gvwilson
added
feature
emilykl
reviewed
Sep 9, 2025
Comment on lines
+86
to
+87
| if not _assert_format(formatted_extension): | ||
| raise ValueError # this line will never be reached its for typer |
Collaborator
There was a problem hiding this comment.
could this be just
Suggested change
| if not _assert_format(formatted_extension): | |
| raise ValueError # this line will never be reached its for typer | |
| _assert_format(formatted_extension) |
?
Collaborator
Author
There was a problem hiding this comment.
yes, but the typechecker doesn't realize whats happened in that case (and things the format is not asserted)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds some testing for some of the more complicated internal utilities.