Skip to content

Commit 3c291d5

Browse files
authored
Merge pull request #459 from plotly/copilot/remove-warnings-get-rows
Stop forwarding `getRowsRequest` / `getRowsResponse` into AG Grid options
2 parents 28f9dbe + 2249a05 commit 3c291d5

3 files changed

Lines changed: 13 additions & 6 deletions

File tree

CHANGELOG.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,8 @@ Links "DE#nnn" prior to version 2.0 point to the Dash Enterprise closed-source D
1515

1616
### Fixed
1717
- [#454](https://github.com/plotly/dash-ag-grid/pull/454) fixes issue where a rowCount of 0 would cause the grid not to display new data
18-
- [#417](https://github.com/plotly/dash-ag-grid/issues/417) fix grid rendering when `getRowId` is explicitly set to `None`
18+
- [#459](https://github.com/plotly/dash-ag-grid/pull/459) removes `getRowsRequest` / `getRowsResponse` warnings by excluding these Dash callback props from AG Grid options.
19+
- [#460](https://github.com/plotly/dash-ag-grid/pull/460) fix grid rendering when `getRowId` is explicitly set to `None`
1920

2021
## [35.2.0] - 2026-04-03
2122
### Added

src/lib/utils/propCategories.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -351,8 +351,8 @@ export const PROPS_NOT_FOR_AG_GRID = [
351351
'cellValueChanged',
352352
'cellClicked',
353353
'cellDoubleClicked',
354-
'getRowRequest',
355-
'getRowResponse',
354+
'getRowsRequest',
355+
'getRowsResponse',
356356
'getDetailRequest',
357357
'getDetailResponse',
358358
'dangerously_allow_code',
@@ -383,7 +383,7 @@ export const OMIT_PROP_RENDER = [
383383
'virtualRowData',
384384
'columnState',
385385
'filterModel',
386-
'getRowRequest',
386+
'getRowsRequest',
387387
'getDetailRequest',
388388
'cellValueChanged',
389389
'cellClicked',

tests/test_infinite_scroll.py

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -247,7 +247,13 @@ def scroll(n):
247247
for x in range(8):
248248
dash_duo.find_element("#scroll").click()
249249
time.sleep(3) # pausing to emulate separation because user inputs
250-
assert list(filter(lambda i: i.get("level") != "WARNING", dash_duo.get_logs())) == []
250+
logs = dash_duo.get_logs()
251+
assert list(filter(lambda i: i.get("level") != "WARNING", logs)) == []
252+
assert not any(
253+
"invalid gridOptions property 'getRowsRequest'" in log.get("message", "")
254+
or "invalid gridOptions property 'getRowsResponse'" in log.get("message", "")
255+
for log in logs
256+
)
251257

252258
def test_is003_infinite_scroll_clear(dash_duo):
253259
app = Dash(__name__)
@@ -330,4 +336,4 @@ def update_rfq_grid_rows(
330336
)
331337
dash_duo.find_element("#reset").click()
332338
grid_dom.wait_for_cell_text(0, 0, "0")
333-
assert x == len(test_data) # make sure the callback was called the expected number of times
339+
assert x == len(test_data) # make sure the callback was called the expected number of times

0 commit comments

Comments
 (0)