Merge branch 'dev' into extract-meta-error-path

Author: T4rk1n

CHANGELOG.md

@@ -2,6 +2,12 @@
 All notable changes to `dash` will be documented in this file.
 This project adheres to [Semantic Versioning](https://semver.org/).
 
+## [UNRELEASED]
+
+## Fixed
+- [#3353](https://github.com/plotly/dash/pull/3353) Support pattern-matching/dict ids in `dcc.Loading` `target_components`
+
+
 # [3.1.1] - 2025-06-29
 
 ## Fixed

components/dash-core-components/src/components/Loading.react.js

@@ -87,6 +87,7 @@ function Loading({
     custom_spinner,
 }) {
     const ctx = window.dash_component_api.useDashContext();
+
     const loading = ctx.useSelector(
         loadingSelector(ctx.componentPath, target_components),
         equals

components/dash-core-components/src/fragments/Slider.react.js

@@ -17,6 +17,8 @@ import {
 } from '../utils/formatSliderTooltip';
 import LoadingElement from '../utils/LoadingElement';
 
+const MAX_MARKS = 500;
+
 const sliderProps = [
     'min',
     'max',
@@ -76,6 +78,21 @@ export default class Slider extends Component {
         } = this.props;
         const value = this.state.value;
 
+        // Check if marks exceed 500 limit for performance
+        let processedMarks = marks;
+        if (marks && typeof marks === 'object' && marks !== null) {
+            const marksCount = Object.keys(marks).length;
+            if (marksCount > MAX_MARKS) {
+                /* eslint-disable no-console */
+                console.error(
+                    `dcc.Slider: Too many marks (${marksCount}) provided. ` +
+                        `For performance reasons, marks are limited to 500. ` +
+                        `Using auto-generated marks instead.`
+                );
+                processedMarks = undefined;
+            }
+        }
+
         let tipProps, tipFormatter;
         if (tooltip) {
             /**
@@ -136,11 +153,16 @@ export default class Slider extends Component {
                     tipFormatter={tipFormatter}
                     style={{position: 'relative'}}
                     value={value}
-                    marks={sanitizeMarks({min, max, marks, step})}
-                    max={setUndefined(min, max, marks).max_mark}
-                    min={setUndefined(min, max, marks).min_mark}
+                    marks={sanitizeMarks({
+                        min,
+                        max,
+                        marks: processedMarks,
+                        step,
+                    })}
+                    max={setUndefined(min, max, processedMarks).max_mark}
+                    min={setUndefined(min, max, processedMarks).min_mark}
                     step={
-                        step === null && !isNil(marks)
+                        step === null && !isNil(processedMarks)
                             ? null
                             : calcStep(min, max, step)
                     }

components/dash-core-components/tests/integration/loading/test_loading_component.py

@@ -1,5 +1,6 @@
 from multiprocessing import Lock
 from dash import Dash, Input, Output, dcc, html
+from dash.dependencies import stringify_id
 from dash.testing import wait
 import time
 
@@ -414,9 +415,9 @@ def updateDiv(n_clicks):
     assert dash_dcc.get_logs() == []
 
 
-# multiple components, only one triggers the spinner
-def test_ldcp010_loading_component_target_components(dash_dcc):
-
+# update multiple props of same component, only targeted id/prop triggers spinner
+# test that target_components id can be a dict id
+def test_ldcp011_loading_component_target_components(dash_dcc):
     lock = Lock()
 
     app = Dash(__name__)
@@ -425,53 +426,61 @@ def test_ldcp010_loading_component_target_components(dash_dcc):
         [
             dcc.Loading(
                 [
-                    html.Button(id="btn-1"),
+                    html.Button(id={"type": "button", "index": "one"}),
                     html.Button(id="btn-2"),
+                    html.Button(id="btn-3"),
                 ],
                 className="loading-1",
-                target_components={"btn-2": "children"},
+                target_components={
+                    stringify_id({"type": "button", "index": "one"}): "className"
+                },
             )
         ],
         id="root",
     )
 
-    @app.callback(Output("btn-1", "children"), [Input("btn-2", "n_clicks")])
+    @app.callback(
+        Output({"type": "button", "index": "one"}, "children"),
+        [Input("btn-2", "n_clicks")],
+    )
     def updateDiv1(n_clicks):
         if n_clicks:
             with lock:
                 return "changed 1"
-
         return "content 1"
 
-    @app.callback(Output("btn-2", "children"), [Input("btn-1", "n_clicks")])
+    @app.callback(
+        Output({"type": "button", "index": "one"}, "className"),
+        [Input("btn-3", "n_clicks")],
+    )
     def updateDiv2(n_clicks):
         if n_clicks:
             with lock:
-                return "changed 2"
-
-        return "content 2"
+                return "new-class"
+        return ""
 
     dash_dcc.start_server(app)
 
-    dash_dcc.wait_for_text_to_equal("#btn-1", "content 1")
-    dash_dcc.wait_for_text_to_equal("#btn-2", "content 2")
-
-    with lock:
-        dash_dcc.find_element("#btn-1").click()
+    btn1id = "#" + stringify_id({"type": "button", "index": "one"})
 
-        dash_dcc.find_element(".loading-1 .dash-spinner")
-        dash_dcc.wait_for_text_to_equal("#btn-2", "")
-
-    dash_dcc.wait_for_text_to_equal("#btn-2", "changed 2")
+    dash_dcc.wait_for_text_to_equal(btn1id, "content 1")
 
     with lock:
         dash_dcc.find_element("#btn-2").click()
-        spinners = dash_dcc.find_elements(".loading-1 .dash-spinner")
-        dash_dcc.wait_for_text_to_equal("#btn-1", "")
 
-    dash_dcc.wait_for_text_to_equal("#btn-1", "changed 1")
+        spinners = dash_dcc.find_elements(".loading-1 .dash-spinner")
+        dash_dcc.wait_for_text_to_equal(btn1id, "")
+    dash_dcc.wait_for_text_to_equal(btn1id, "changed 1")
     assert spinners == []
 
+    with lock:
+        dash_dcc.find_element("#btn-3").click()
+
+        dash_dcc.find_element(".loading-1 .dash-spinner")
+        dash_dcc.wait_for_text_to_equal(btn1id, "")
+
+    dash_dcc.wait_for_class_to_equal(btn1id, "new-class")
+
     assert dash_dcc.get_logs() == []
 
 

components/dash-core-components/tests/integration/sliders/test_sliders.py

@@ -616,3 +616,50 @@ def test_sls016_sliders_format_tooltips(dash_dcc):
     dash_dcc.percy_snapshot("sliders-format-tooltips")
 
     assert dash_dcc.get_logs() == []
+
+
+def test_slsl017_marks_limit_500(dash_dcc):
+    """Test that slider works with exactly 500 marks"""
+    app = Dash(__name__)
+    marks_500 = {str(i): f"Mark {i}" for i in range(500)}
+    app.layout = html.Div(
+        [
+            dcc.Slider(id="slider", min=0, max=499, marks=marks_500, value=250),
+            html.Div(id="output"),
+        ]
+    )
+
+    @app.callback(Output("output", "children"), [Input("slider", "value")])
+    def update_output(value):
+        return f"Selected: {value}"
+
+    dash_dcc.start_server(app)
+    dash_dcc.wait_for_text_to_equal("#output", "Selected: 250")
+
+    # No warnings should be logged for 500 marks
+    assert dash_dcc.get_logs() == []
+
+
+def test_slsl018_marks_limit_exceeded(dash_dcc):
+    """Test behavior when marks exceed 500 limit"""
+    app = Dash(__name__)
+    marks_501 = {str(i): f"Mark {i}" for i in range(501)}
+    app.layout = html.Div(
+        [
+            dcc.Slider(id="slider", min=0, max=500, marks=marks_501, value=250),
+            html.Div(id="output"),
+        ]
+    )
+
+    @app.callback(Output("output", "children"), [Input("slider", "value")])
+    def update_output(value):
+        return f"Selected: {value}"
+
+    dash_dcc.start_server(app)
+    dash_dcc.wait_for_text_to_equal("#output", "Selected: 250")
+
+    # Check that warning is logged
+    logs = dash_dcc.get_logs()
+    assert len(logs) > 0
+    warning_found = any("Too many marks" in log["message"] for log in logs)
+    assert warning_found, "Expected warning about too many marks not found in logs"

components/dash-table/.config/webpack/base.js

@@ -31,7 +31,7 @@ module.exports = (options = {}) => {
                 type: 'window',
             }
         },
-        devtool: 'source-map',
+        devtool: mode === 'development' ? 'source-map' : false,
         externals: {
             react: 'React',
             'react-dom': 'ReactDOM',
@@ -53,31 +53,31 @@ module.exports = (options = {}) => {
                     test: /\.ts(x?)$/,
                     include: /node_modules[\\\/](highlight[.]js|d3-format)[\\\/]/,
                     use: [
-                        { loader: 'babel-loader', options: babel },
-                        { loader: 'ts-loader', options: ts },
+                        { loader: 'babel-loader', options: { ...babel, cacheDirectory: true } },
+                        { loader: 'ts-loader', options: { ...ts, transpileOnly: true } },
                     ]
                 },
                 {
                     test: /\.ts(x?)$/,
                     exclude: /node_modules/,
                     use: [
-                        { loader: 'babel-loader', options: babel },
-                        { loader: 'ts-loader', options: ts },
+                        { loader: 'babel-loader', options: { ...babel, cacheDirectory: true } },
+                        { loader: 'ts-loader', options: { ...ts, transpileOnly: true } },
                         { loader: 'webpack-preprocessor', options: JSON.stringify(preprocessor) }
                     ]
                 },
                 {
                     test: /\.js$/,
                     include: /node_modules[\\\/](highlight[.]js|d3-format)[\\\/]/,
                     use: [
-                        { loader: 'babel-loader', options: babel }
+                        { loader: 'babel-loader', options: { ...babel, cacheDirectory: true } }
                     ]
                 },
                 {
                     test: /\.js$/,
                     exclude: /node_modules/,
                     use: [
-                        { loader: 'babel-loader', options: babel },
+                        { loader: 'babel-loader', options: { ...babel, cacheDirectory: true } },
                         { loader: 'webpack-preprocessor', options: JSON.stringify(preprocessor) }
                     ]
                 },
@@ -98,6 +98,12 @@ module.exports = (options = {}) => {
                 }
             ]
         },
+        cache: {
+            type: 'filesystem',
+            buildDependencies: {
+                config: [__filename]
+            }
+        },
         resolve: {
             alias: {
                 'dash-table': path.resolve('./src/dash-table'),