Merge branch 'dev' into fix-slider-mark-height

Author: KoolADE85

.github/workflows/testing.yml

@@ -94,6 +94,7 @@ jobs:
   test-typing:
     name: Typing Tests
     runs-on: ubuntu-latest
+    if: github.ref_name != 'master'
     needs: build
     timeout-minutes: 30
     strategy:

components/dash-core-components/src/components/Graph.react.js

@@ -550,6 +550,11 @@ PlotlyGraph.propTypes = {
          * plot rather than registering them globally.
          */
         locales: PropTypes.object,
+
+        /**
+         * Determines whether or not notifier is displayed
+         */
+        displayNotifier: PropTypes.bool,
     }),
 
     /**

components/dash-core-components/tests/integration/loading/test_loading_component.py

@@ -1,5 +1,5 @@
 from multiprocessing import Lock
-from dash import Dash, Input, Output, dcc, html
+from dash import Dash, Input, Output, dcc, html, MATCH, ALL
 from dash.dependencies import stringify_id
 from dash.testing import wait
 import time
@@ -417,7 +417,7 @@ def updateDiv(n_clicks):
 
 # update multiple props of same component, only targeted id/prop triggers spinner
 # test that target_components id can be a dict id
-def test_ldcp011_loading_component_target_components(dash_dcc):
+def test_ldcp010_loading_component_target_components(dash_dcc):
     lock = Lock()
 
     app = Dash(__name__)
@@ -461,7 +461,7 @@ def updateDiv2(n_clicks):
 
     dash_dcc.start_server(app)
 
-    btn1id = "#" + stringify_id({"type": "button", "index": "one"})
+    btn1id = "[id='" + stringify_id({"type": "button", "index": "one"}) + "']"
 
     dash_dcc.wait_for_text_to_equal(btn1id, "content 1")
 
@@ -839,3 +839,50 @@ def update_btn1_children(n_clicks):
     assert spinners == []
 
     assert dash_dcc.get_logs() == []
+
+
+# loading spinner triggers when callback Output uses ALL wildcard
+def test_ldcp019_loading_component_pattern_matching(dash_dcc):
+    lock = Lock()
+
+    app = Dash(__name__)
+
+    app.layout = html.Div(
+        [
+            dcc.Loading(
+                [
+                    html.Div(
+                        id={"type": "div-1", "index": 1, "name": "test"},
+                        className="div-1",
+                    )
+                ],
+                className="loading",
+            )
+        ],
+        id={"type": "root", "index": 1, "name": "test"},
+        className="root",
+    )
+
+    @app.callback(
+        Output({"type": "div-1", "index": ALL, "name": MATCH}, "children"),
+        Input({"type": "root", "index": ALL, "name": MATCH}, "n_clicks"),
+    )
+    def updateDiv(n_clicks):
+        if n_clicks == [1]:
+            time.sleep(0.1)
+            return ["changed"]
+        return ["content"]
+
+    with lock:
+        dash_dcc.start_server(app)
+        dash_dcc.wait_for_text_to_equal(".div-1", "content")
+
+        dash_dcc.find_element(".root").click()
+
+        dash_dcc.find_element(".loading .dash-spinner")
+        # mounted but hidden, so looks like no text
+        dash_dcc.wait_for_text_to_equal(".div-1", "")
+
+    dash_dcc.wait_for_text_to_equal(".div-1", "changed")
+
+    assert dash_dcc.get_logs() == []

components/dash-core-components/tests/integration/tab/test_tabs_with_graphs.py

@@ -1,7 +1,5 @@
 from dash import Dash, Input, Output, dcc, html
 from dash.exceptions import PreventUpdate
-import json
-import os
 import pytest
 from selenium.webdriver.common.by import By
 from selenium.webdriver.support import expected_conditions as EC
@@ -185,43 +183,4 @@ def on_click_update_graph(n_clicks):
     time.sleep(1)
     dash_dcc.percy_snapshot(f"Tabs-2 rendered ({is_eager})")
 
-    # do some extra tests while we're here
-    # and have access to Graph and plotly.js
-    check_graph_config_shape(dash_dcc)
-
-    assert dash_dcc.get_logs() == []
-
-
-def check_graph_config_shape(dash_dcc):
-    config_schema = dash_dcc.driver.execute_script(
-        "return Plotly.PlotSchema.get().config;"
-    )
-    with open(os.path.join(dcc.__path__[0], "metadata.json")) as meta:
-        graph_meta = json.load(meta)["src/components/Graph.react.js"]
-        config_prop_shape = graph_meta["props"]["config"]["type"]["value"]
-
-    ignored_config = [
-        "setBackground",
-        "showSources",
-        "logging",
-        "globalTransforms",
-        "notifyOnLogging",
-        "role",
-        "typesetMath",
-    ]
-
-    def crawl(schema, props):
-        for prop_name in props:
-            assert prop_name in schema
-
-        for item_name, item in schema.items():
-            if item_name in ignored_config:
-                continue
-
-            assert item_name in props
-            if "valType" not in item:
-                crawl(item, props[item_name]["value"])
-
-    crawl(config_schema, config_prop_shape)
-
     assert dash_dcc.get_logs() == []

dash/dash-renderer/src/actions/callbacks.ts

@@ -791,7 +791,7 @@ export function executeCallback(
         }
 
         const __execute = async (): Promise<CallbackResult> => {
-            const loadingOutputs = outputs.map(out => ({
+            const loadingOutputs = flatten(outputs).map(out => ({
                 path: getPath(paths, out.id),
                 property: out.property?.split('@')[0],
                 id: stringifyId(out.id)