code review feedback

Author: KoolADE85

components/dash-core-components/src/components/css/dropdown.css

@@ -63,6 +63,7 @@
     background: var(--Dash-Fill-Inverse-Strong);
     min-width: fit-content;
     width: var(--radix-popover-trigger-width);
+    overflow-y: auto;
     z-index: 50;
     box-shadow: 0px 10px 38px -10px rgba(22, 23, 24, 0.35),
         0px 10px 20px -15px rgba(22, 23, 24, 0.2);

components/dash-core-components/src/fragments/Dropdown.tsx

@@ -256,6 +256,7 @@ const Dropdown = (props: DropdownProps) => {
         const finalValue: DropdownProps['value'] = multi ? [] : null;
         setProps({value: finalValue});
     }, [multi]);
+
     const handleSelectAll = useCallback(() => {
         if (multi) {
             const allValues = sanitizedValues.concat(
@@ -487,9 +488,7 @@ const Dropdown = (props: DropdownProps) => {
                         onOpenAutoFocus={e => e.preventDefault()}
                         onKeyDown={handleKeyDown}
                         style={{
-                            width: 'var(--radix-popover-trigger-width)',
                             maxHeight: maxHeight ? `${maxHeight}px` : 'auto',
-                            overflowY: 'auto',
                         }}
                     >
                         {searchable && (

tests/integration/renderer/test_children_reorder.py

@@ -62,9 +62,6 @@ def swap_button_action(n_clicks, children):
 
     for i in range(2):
         dash_duo.wait_for_text_to_equal("h1", f"I am section {i}")
-        # dash_duo.wait_for_text_to_equal(
-        #     f".dropdown_{i} .Select-multi-value-wrapper", "Select..."
-        # )
         dash_duo.find_element(f".dropdown_{i}").click()
         dash_duo.find_element(
             f".dropdown_{i} .dash-dropdown-option:nth-child(1)"