code review feedback

Author: KoolADE85

CHANGELOG.md

@@ -9,6 +9,7 @@ This project adheres to [Semantic Versioning](https://semver.org/).
 
 ## Fixed
 - [#3629](https://github.com/plotly/dash/pull/3629) Fix date pickers not showing date when initially rendered in a hidden container.
+- [#3627][(](https://github.com/plotly/dash/pull/3627)) Make dropdowns searchable wheen focused, without requiring to open them first
 
 
 

components/dash-core-components/src/fragments/Dropdown.tsx

@@ -539,9 +539,18 @@ const Dropdown = (props: DropdownProps) => {
                                     const firstVal = displayOptions[0].value;
                                     const isSelected =
                                         sanitizedValues.includes(firstVal);
-                                    const newSelection = isSelected
-                                        ? without([firstVal], sanitizedValues)
-                                        : append(firstVal, sanitizedValues);
+                                    let newSelection;
+                                    if (isSelected) {
+                                        newSelection = without(
+                                            [firstVal],
+                                            sanitizedValues
+                                        );
+                                    } else {
+                                        newSelection = append(
+                                            firstVal,
+                                            sanitizedValues
+                                        );
+                                    }
                                     updateSelection(newSelection);
                                 }}
                                 ref={searchInputRef}

components/dash-core-components/tests/integration/dropdown/test_a11y.py

@@ -678,7 +678,11 @@ def update_output(value):
     dash_duo.wait_for_text_to_equal("#output", "Selected: Cambodia")
 
     # Type "can" — should filter to only Canada
-    send_keys("can")
+    send_keys("c")
+    sleep(0.1)
+    send_keys("a")
+    sleep(0.1)
+    send_keys("n")
     sleep(0.1)
     options = dash_duo.find_elements(".dash-dropdown-option")
     assert len(options) == 1