improved grrs001 timing

Author: T4rk1n

components/dash-core-components/tests/integration/graph/test_graph_responsive.py

@@ -4,18 +4,35 @@
 import flaky
 
 from dash import Dash, Input, Output, State, dcc, html
-import plotly.graph_objects as go
 
 from dash.exceptions import PreventUpdate
 from dash.testing import wait
 
 
-@pytest.mark.parametrize("responsive", [True, False, None])
-@pytest.mark.parametrize("autosize", [True, False, None])
-@pytest.mark.parametrize("height", [600, None])
-@pytest.mark.parametrize("width", [600, None])
-@pytest.mark.parametrize("is_responsive", [True, False, "auto"])
-def test_grrs001_graph(dash_dcc, responsive, autosize, height, width, is_responsive):
+@pytest.mark.parametrize(
+    "is_responsive,responsive,autosize,height,width",
+    [
+        # is_responsive=True: always responsive regardless of other params
+        (True, None, None, None, None),
+        (True, False, False, 600, 600),  # still responsive even with fixed dims
+        # is_responsive=False: never responsive regardless of other params
+        (False, True, True, None, None),  # not responsive even with autosize
+        (False, None, None, 600, 600),
+        # is_responsive="auto": behavior depends on other params
+        ("auto", True, True, None, None),  # responsive: all conditions met
+        ("auto", True, True, 600, None),  # responsive: one dim fixed is ok
+        ("auto", True, False, None, None),  # NOT responsive: autosize=False
+        (
+            "auto",
+            False,
+            True,
+            None,
+            None,
+        ),  # NOT responsive on resize: config.responsive=False
+        ("auto", None, None, 600, 600),  # NOT responsive: both dims fixed
+    ],
+)
+def test_grrs001_graph(dash_dcc, is_responsive, responsive, autosize, height, width):
     app = Dash(__name__, eager_loading=True)
 
     header_style = dict(padding="10px", backgroundColor="yellow", flex="0 0 100px")

tests/background_callback/conftest.py

@@ -27,6 +27,6 @@ def cleanup_background_processes():
             cmdline_str = " ".join(cmdline) if cmdline else ""
             if "celery" in cmdline_str and "worker" in cmdline_str:
                 proc.kill()
-                proc.wait(timeout=3)
-        except (psutil.NoSuchProcess, psutil.AccessDenied, psutil.TimeoutExpired):
+        except (psutil.NoSuchProcess, psutil.AccessDenied):
             pass
+    # Don't wait - just kill and move on

tests/background_callback/utils.py

@@ -68,31 +68,27 @@ def get_background_callback_manager():
 
 def kill(proc_pid):
     try:
-        process = psutil.Process(proc_pid)
-        children = process.children(recursive=True)
-
-        # Kill children first
-        for proc in children:
-            try:
-                proc.kill()
-            except (psutil.NoSuchProcess, psutil.AccessDenied):
-                pass
-
-        # Kill the main process
+        # Kill by process group first to get all children
         try:
-            process.kill()
-        except (psutil.NoSuchProcess, psutil.AccessDenied):
+            os.killpg(proc_pid, 9)  # SIGKILL
+        except (ProcessLookupError, PermissionError, OSError):
             pass
 
-        # Also kill by process group to catch any orphans
+        # Also kill individual processes in case they escaped the group
         try:
-            os.killpg(proc_pid, 9)  # SIGKILL
-        except (ProcessLookupError, PermissionError, OSError):
+            process = psutil.Process(proc_pid)
+            children = process.children(recursive=True)
+            for proc in children:
+                try:
+                    proc.kill()
+                except (psutil.NoSuchProcess, psutil.AccessDenied):
+                    pass
+            process.kill()
+        except (psutil.NoSuchProcess, psutil.AccessDenied):
             pass
 
-        # Wait for processes to actually terminate
-        procs_to_wait = [process] + children
-        psutil.wait_procs(procs_to_wait, timeout=5)
+        # Brief wait - don't block too long
+        time.sleep(0.5)
 
     except psutil.NoSuchProcess:
         pass
@@ -153,6 +149,9 @@ def setup_background_callback_app(manager_name, app_name):
             os.environ.pop("LONG_CALLBACK_MANAGER")
             os.environ.pop("CELERY_BROKER")
             os.environ.pop("CELERY_BACKEND")
+            # Close stderr to prevent blocking on pipe buffer
+            if worker.stderr:
+                worker.stderr.close()
             kill(worker.pid)
             from dash import page_registry