lint

Author: KoolADE85

.github/workflows/testing.yml

@@ -105,6 +105,8 @@ jobs:
           echo "DISPLAY=:99" >> $GITHUB_ENV
 
       - name: Run lint
+        env:
+          PYLINT_EXTRA_ARGS: ${{ matrix.python-version == '3.8' && '--ignored-modules=mcp' || '' }}
         run: npm run lint
 
       - name: Run unit tests

.pylintrc

@@ -431,7 +431,7 @@ max-returns=6
 max-statements=50
 
 # Minimum number of public methods for a class (see R0903).
-min-public-methods=2
+min-public-methods=1
 
 
 [IMPORTS]

dash/mcp/primitives/tools/callback_adapter.py

@@ -135,7 +135,8 @@ def output_id(self) -> str:
 
     @property
     def tool_name(self) -> str:
-        return get_app().mcp_callback_map._tool_names_map[self._output_id]  # pylint: disable=protected-access
+        # pylint: disable-next=protected-access
+        return get_app().mcp_callback_map._tool_names_map[self._output_id]
 
     @cached_property
     def prevents_initial_call(self) -> bool:

dash/mcp/primitives/tools/descriptions/description_docstring.py

@@ -25,13 +25,14 @@ class DocstringDescription(ToolDescriptionSource):
     def describe(cls, callback: CallbackAdapter) -> list[str]:
         if not cls._is_exposed(callback):
             return []
-        docstring = callback._docstring
+        docstring = callback._docstring  # pylint: disable=protected-access
         if docstring:
             return ["", docstring.strip()]
         return []
 
     @classmethod
     def _is_exposed(cls, callback: CallbackAdapter) -> bool:
+        # pylint: disable-next=protected-access
         per_callback = callback._cb_info.get("mcp_expose_docstring")
         if per_callback is not None:
             return per_callback

dash/mcp/primitives/tools/input_schemas/schema_callback_type_annotations.py

@@ -39,7 +39,7 @@ def annotation_to_json_schema(annotation: type) -> dict[str, Any] | None:
 
     try:
         return TypeAdapter(annotation).json_schema()
-    except Exception:
+    except Exception:  # pylint: disable=broad-exception-caught
         return None
 
 

package.json

@@ -14,7 +14,7 @@
     "private::build.jupyterlab": "cd @plotly/dash-jupyterlab && jlpm install && jlpm build:pack",
     "private::lint.black": "black dash tests --exclude 'metadata_test.py|node_modules' --check",
     "private::lint.flake8": "flake8 dash tests",
-    "private::lint.pylint-dash": "pylint dash setup.py --rcfile=.pylintrc",
+    "private::lint.pylint-dash": "pylint dash setup.py --rcfile=.pylintrc ${PYLINT_EXTRA_ARGS:-}",
     "private::lint.pylint-tests": "pylint tests/unit tests/integration -d all -e C0410,C0413,W0109 --rcfile=.pylintrc",
     "private::lint.renderer": "cd dash/dash-renderer && npm run lint",
     "private::test.setup-components": "cd @plotly/dash-test-components && npm ci && npm run build",