Conversation
There was a problem hiding this comment.
@T4rk1n Are these linting steps the same as what is triggered by npm run lint ?
There was a problem hiding this comment.
Not really, it just lint the files that are staged and run the commands with fail-fast. But in the end it runs the proper linting for the files that changed, it cd to the proper sub npm package for eslint/prettier config of those.
There was a problem hiding this comment.
Gotcha. Just want to make sure we don't end up in a situation where this script lints the files differently than npm run lint.
Is there a risk of that happening in the future if someone edits this file but not package.json?
Should we remove the npm run lint commands entirely? Or can we make package.json and this script both refer to the same source of truth?
venvor.venvin the pre-commit hook if they are available.No need to
--no-verifyanymore.