Skip to content

dcc redesign: accumulated bugfixes#3459

Merged
KoolADE85 merged 18 commits intov4from
bugfix/dcc-redesign-bugfixes
Oct 3, 2025
Merged

dcc redesign: accumulated bugfixes#3459
KoolADE85 merged 18 commits intov4from
bugfix/dcc-redesign-bugfixes

Conversation

@KoolADE85
Copy link
Copy Markdown
Contributor

@KoolADE85 KoolADE85 commented Sep 30, 2025 •
edited
Loading

This PR addresses issues/bugs reported so far in the existing redesigned components:

  • fix bug with step in sliders and add relevant tests
  • add localizations prop to dropdowns to allow customization of hard-coded text
  • improve display of very long (wide) dropdown options
  • improve accessibility of dropdown & option lists (screen reader improvements and fix labels' htmlFor prop not working)
  • add visual focus state to inputs
  • add CSS variables for shadow colours
  • fix className in slider so that it is applied at the top level of the component.

To see the fixes one-by-one, just go through the commits.

@KoolADE85 KoolADE85 changed the base branch from dev to v4 September 30, 2025 00:03
@KoolADE85 KoolADE85 marked this pull request as ready for review September 30, 2025 00:19
@gvwilson gvwilson added feature something new P1 needed for current cycle labels Oct 1, 2025
@gvwilson
Copy link
Copy Markdown
Contributor

gvwilson commented Oct 1, 2025

@T4rk1n @AnnMarieW if you have time to do a review, it would be very welcome - thanks

@AnnMarieW
Copy link
Copy Markdown
Collaborator

AnnMarieW commented Oct 1, 2025 •
edited
Loading

This is great! Just a couple comments:

  • Good that the focused state style was added on the Inputs, but can it be more subtle? - like the focus of the search box in the Dropdown?

  • Can a disabled state style also be added? In previous version the background was a gray color. Or for consistency, it could have the same cursor style as when the Dropdown is disabled.

Input:
image

Dropdown
image

@AnnMarieW
Copy link
Copy Markdown
Collaborator

AnnMarieW commented Oct 1, 2025

Also, any other comments on the issues raised in #3449?

T4rk1n
T4rk1n reviewed Oct 1, 2025
View reviewed changes
Comment thread components/dash-core-components/src/components/Dropdown.tsx Outdated
@KoolADE85 KoolADE85 force-pushed the bugfix/dcc-redesign-bugfixes branch from 2d1cfe3 to a2c28b7 Compare October 2, 2025 19:18
@KoolADE85
Copy link
Copy Markdown
Contributor Author

KoolADE85 commented Oct 2, 2025

This PR addresses most of what's in #3449, except for the cross-component consistency portion. I'd like to tackle that portion as a separate PR!

T4rk1n
T4rk1n reviewed Oct 3, 2025
View reviewed changes
Comment thread components/dash-core-components/src/types.ts Outdated
T4rk1n
T4rk1n approved these changes Oct 3, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@T4rk1n T4rk1n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just the docstring for the new prop should be changed.

@KoolADE85 KoolADE85 merged commit 391f0c8 into v4 Oct 3, 2025
9 checks passed
@KoolADE85 KoolADE85 deleted the bugfix/dcc-redesign-bugfixes branch October 3, 2025 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@T4rk1n T4rk1n T4rk1n approved these changes

@ndrezn ndrezn Awaiting requested review from ndrezn ndrezn is a code owner

@gvwilson gvwilson Awaiting requested review from gvwilson

@emilykl emilykl Awaiting requested review from emilykl emilykl is a code owner

Assignees

@KoolADE85 KoolADE85

Labels

feature something new P1 needed for current cycle

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@KoolADE85 @gvwilson @AnnMarieW @T4rk1n