make parcoord font size dflt scale linearly with global font

- N.B. this keeps the 10px default

Author: etpinard

src/traces/parcoords/attributes.js

@@ -17,7 +17,6 @@ var fontAttrs = require('../../plots/font_attributes');
 var extendDeep = require('../../lib/extend').extendDeep;
 var extendFlat = require('../../lib/extend').extendFlat;
 
-
 module.exports = {
 
     domain: {
@@ -49,9 +48,15 @@ module.exports = {
         }
     },
 
-    labelfont: extendFlat({}, fontAttrs, {dflt: {size: 10}, description: 'Sets the font for the `dimension` labels.'}),
-    tickfont: extendFlat({}, fontAttrs, {dflt: {size: 10}, description: 'Sets the font for the `dimension` tick values.'}),
-    rangefont: extendFlat({}, fontAttrs, {dflt: {size: 10}, description: 'Sets the font for the `dimension` range values.'}),
+    labelfont: extendFlat({}, fontAttrs, {
+        description: 'Sets the font for the `dimension` labels.'
+    }),
+    tickfont: extendFlat({}, fontAttrs, {
+        description: 'Sets the font for the `dimension` tick values.'
+    }),
+    rangefont: extendFlat({}, fontAttrs, {
+        description: 'Sets the font for the `dimension` range values.'
+    }),
 
     dimensions: {
         _isLinkedToArray: 'dimension',

src/traces/parcoords/defaults.js

@@ -81,10 +81,6 @@ function dimensionsDefaults(traceIn, traceOut) {
     return dimensionsOut;
 }
 
-function coerceFont(fontAttr, coerce, layoutFont, defaultFont) {
-    Lib.coerceFont(coerce, fontAttr, Lib.extendFlat({}, layoutFont, defaultFont, fontAttr));
-}
-
 module.exports = function supplyDefaults(traceIn, traceOut, defaultColor, layout) {
     function coerce(attr, dflt) {
         return Lib.coerce(traceIn, traceOut, attributes, attr, dflt);
@@ -101,7 +97,15 @@ module.exports = function supplyDefaults(traceIn, traceOut, defaultColor, layout
         traceOut.visible = false;
     }
 
-    coerceFont('labelfont', coerce, layout.font, attributes.labelfont.dflt || {});
-    coerceFont('tickfont', coerce, layout.font, attributes.tickfont.dflt || {});
-    coerceFont('rangefont', coerce, layout.font, attributes.rangefont.dflt || {});
+    // make default font size 10px,
+    // scale linearly with global font size
+    var fontDflt = {
+        family: layout.font.family,
+        size: Math.round(layout.font.size * (10 / 12)),
+        color: layout.font.color
+    };
+
+    Lib.coerceFont(coerce, 'labelfont', fontDflt);
+    Lib.coerceFont(coerce, 'tickfont', fontDflt);
+    Lib.coerceFont(coerce, 'rangefont', fontDflt);
 };

test/jasmine/tests/parcoords_test.js

@@ -38,14 +38,34 @@ describe('parcoords initialization tests', function() {
             expect(gd._fullData[0].opacity).toBeUndefined();
         });
 
+        it('should use global font as label, tick and range font defaults', function() {
+            var gd = Lib.extendDeep({}, mock1);
+            gd.layout.font = {
+                family: 'Gravitas',
+                size: 20,
+                color: 'blue'
+            };
+
+            Plots.supplyDefaults(gd);
+
+            var expected = {
+                family: 'Gravitas',
+                size: 17,
+                color: 'blue'
+            };
+
+            expect(gd._fullData[0].labelfont).toEqual(expected);
+            expect(gd._fullData[0].tickfont).toEqual(expected);
+            expect(gd._fullData[0].rangefont).toEqual(expected);
+        });
     });
 
     describe('parcoords defaults', function() {
 
         function _supply(traceIn) {
             var traceOut = { visible: true },
                 defaultColor = '#444',
-                layout = { };
+                layout = { font: Plots.layoutAttributes.font };
 
             Parcoords.supplyDefaults(traceIn, traceOut, defaultColor, layout);