throw error when setting transform attrs with NaNs

etpinard · etpinard · commit 440ca0de5640 · 2019-02-11T14:51:20.000-05:00
diff --git a/test/image/strict-d3.js b/test/image/strict-d3.js
@@ -58,6 +58,10 @@ function checkAttrVal(sel, key, val) {
     if(/--/.test(val) && isNumeric(val.split('--')[1].charAt(0))) {
         throw new Error('d3 selection.attr called with value ' + val + ' which includes a double negative');
     }
+
+    if(/transform/.test(key) && /NaN/.test(val)) {
+        throw new Error('d3 selection.attr called with ' + key + ' ' + val + ' containing a NaN');
+    }
 }
 
 function checkStyleVal(sel, key, val) {

Original file line number	Diff line number	Diff line change
`@@ -58,6 +58,10 @@ function checkAttrVal(sel, key, val) {`
`58`	`58`	`if(/--/.test(val) && isNumeric(val.split('--')[1].charAt(0))) {`
`59`	`59`	`throw new Error('d3 selection.attr called with value ' + val + ' which includes a double negative');`
`60`	`60`	`}`
	`61`	`+`
	`62`	`+ if(/transform/.test(key) && /NaN/.test(val)) {`
	`63`	`+ throw new Error('d3 selection.attr called with ' + key + ' ' + val + ' containing a NaN');`
	`64`	`+ }`
`61`	`65`	`}`
`62`	`66`
`63`	`67`	`function checkStyleVal(sel, key, val) {`