do not accept number as box/violin x0 on multicategory axes

Author: etpinard

src/plots/cartesian/set_convert.js

@@ -188,13 +188,16 @@ module.exports = function setConvert(ax, fullLayout) {
     }
 
     function getCategoryIndex(v) {
-        // d2l/d2c variant that that won't add categories but will also
-        // allow numbers to be mapped to the linearized axis positions
         if(ax._categoriesMap) {
-            var index = ax._categoriesMap[v];
-            if(index !== undefined) return index;
+            return ax._categoriesMap[v];
         }
+    }
 
+    function getCategoryPosition(v) {
+        // d2l/d2c variant that that won't add categories but will also
+        // allow numbers to be mapped to the linearized axis positions
+        var index = getCategoryIndex(v);
+        if(index !== undefined) return index;
         if(isNumeric(v)) return +v;
     }
 
@@ -280,15 +283,15 @@ module.exports = function setConvert(ax, fullLayout) {
         ax.d2c = ax.d2l = setCategoryIndex;
         ax.r2d = ax.c2d = ax.l2d = getCategoryName;
 
-        ax.d2r = ax.d2l_noadd = getCategoryIndex;
+        ax.d2r = ax.d2l_noadd = getCategoryPosition;
 
         ax.r2c = function(v) {
-            var index = getCategoryIndex(v);
+            var index = getCategoryPosition(v);
             return index !== undefined ? index : ax.fraction2r(0.5);
         };
 
         ax.l2r = ax.c2r = ensureNumber;
-        ax.r2l = getCategoryIndex;
+        ax.r2l = getCategoryPosition;
 
         ax.d2p = function(v) { return ax.l2p(ax.r2c(v)); };
         ax.p2d = function(px) { return getCategoryName(p2l(px)); };
@@ -306,15 +309,17 @@ module.exports = function setConvert(ax, fullLayout) {
         // account all data array items as in ax.makeCalcdata.
 
         ax.r2d = ax.c2d = ax.l2d = getCategoryName;
-        ax.d2r = ax.d2l_noadd = getCategoryIndex;
+        ax.d2r = ax.d2l_noadd = getCategoryPosition;
 
         ax.r2c = function(v) {
-            var index = getCategoryIndex(v);
+            var index = getCategoryPosition(v);
             return index !== undefined ? index : ax.fraction2r(0.5);
         };
 
+        ax.r2c_just_indices = getCategoryIndex;
+
         ax.l2r = ax.c2r = ensureNumber;
-        ax.r2l = getCategoryIndex;
+        ax.r2l = getCategoryPosition;
 
         ax.d2p = function(v) { return ax.l2p(ax.r2c(v)); };
         ax.p2d = function(px) { return getCategoryName(p2l(px)); };

src/traces/box/calc.js

@@ -179,7 +179,7 @@ function getPos(trace, posLetter, posAxis, val, num) {
     }
 
     var pos0c = posAxis.type === 'multicategory' ?
-        posAxis.r2c(pos0) :
+        posAxis.r2c_just_indices(pos0) :
         posAxis.d2c(pos0, 0, trace[posLetter + 'calendar']);
 
     return val.map(function() { return pos0c; });

test/image/baselines/box-violin-x0-category-position.png

@@ -16,18 +16,19 @@
     },
     {
       "y": [ 0.6, 0.7, 0.3, 0.6, 0, 0.5, 0.7, 0.9, 0.5, 0.8, 0.7, 0.2, 0.1, 0.3, 0.1, 0.9, 0.6, 0.6, 0.9, 1, 0.3, 0.6, 0.8, 0.5, 0.6, 0.7, 0.3, 0.6, 0, 0.5, 0.7, 0.9, 0.5, 0.8, 0.7, 0.2 ],
-      "x0": 0.5,
+      "x0": ["2017", "day 1"],
       "type": "violin"
     },
     {
       "y": [ 0.6, 0.7, 0.3, 0.6, 0, 0.5, 0.7, 0.9, 0.5, 0.8, 0.7, 0.2, 0.1, 0.3, 0.1, 0.9, 0.6, 0.6, 0.9, 1, 0.3, 0.6, 0.8, 0.5, 0.6, 0.7, 0.3, 0.6, 0, 0.5, 0.7, 0.9, 0.5, 0.8, 0.7, 0.2 ],
-      "x0": ["2017", "day 1"],
+      "x0": "2017,day 2",
       "type": "violin"
     },
     {
       "y": [ 0.6, 0.7, 0.3, 0.6, 0, 0.5, 0.7, 0.9, 0.5, 0.8, 0.7, 0.2, 0.1, 0.3, 0.1, 0.9, 0.6, 0.6, 0.9, 1, 0.3, 0.6, 0.8, 0.5, 0.6, 0.7, 0.3, 0.6, 0, 0.5, 0.7, 0.9, 0.5, 0.8, 0.7, 0.2 ],
-      "x0": "2017,day 2",
-      "type": "violin"
+      "x0": "1",
+      "type": "violin",
+      "name": "SHOULD NOT BE VISIBLE"
     },
 
     {
@@ -47,6 +48,13 @@
       "type": "violin",
       "xaxis": "x2",
       "yaxis": "y2"
+    },
+    {
+      "y": [ 0.6, 0.7, 0.3, 0.6, 0, 0.5, 0.7, 0.9, 0.5, 0.8, 0.7, 0.2, 0.1, 0.3, 0.1, 0.9, 0.6, 0.6, 0.9, 1, 0.3, 0.6, 0.8, 0.5, 0.6, 0.7, 0.3, 0.6, 0, 0.5, 0.7, 0.9, 0.5, 0.8, 0.7, 0.2 ],
+      "x0": 2,
+      "type": "violin",
+      "xaxis": "x2",
+      "yaxis": "y2"
     }
   ],
   "layout": {
@@ -56,13 +64,6 @@
       "pattern": "independent"
     },
     "annotations": [
-      {
-        "xref": "x",
-        "yref": "y",
-        "x": 0.5,
-        "text": "violin at x0:0.5",
-        "y": 1.5
-      },
       {
         "xref": "x",
         "yref": "y",
@@ -76,13 +77,20 @@
         "x": "2017,day 2",
         "text": "violin at x0:\"2017,day 2\"",
         "y": 1.5,
-        "ay": -50
+        "ax": 20
       },
       {
         "xref": "x2",
         "yref": "y2",
         "x": "day 2",
-        "text": "box at x0:\"day 2\"",
+        "text": "violin at x0:\"day 2\"",
+        "y": 1.5
+      },
+      {
+        "xref": "x2",
+        "yref": "y2",
+        "x": 2,
+        "text": "violin at x0:2",
         "y": 1.5
       }
     ],