Skip to content

Commit 4d442ca

Browse files
authored
Merge pull request #7733 from NssGourav/docs/fix-typos-and-grammar
docs: fix minor typos, grammar, and formatting
2 parents 7aac171 + df559c8 commit 4d442ca

File tree

6 files changed

+27
-22
lines changed

6 files changed

+27
-22
lines changed

BUILDING.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ The sections below provide additional info in respect to alternative building fr
66
---
77
## Angular CLI
88

9-
Since Angular uses webpack under the hood and doesn't allow easily to change it's webpack configuration, there is some work needed using a `custom-webpack` builder to get things going.
9+
Since Angular uses webpack under the hood and doesn't easily allow changing its webpack configuration, there is some work needed using a `custom-webpack` builder to get things going.
1010

1111
1. Install [`@angular-builders/custom-webpack`](https://www.npmjs.com/package/@angular-builders/custom-webpack) and [ify-loader@v1.1.0+](https://github.com/hughsk/ify-loader)
1212
2. Create a new `extra-webpack.config.js` beside `angular.json`.
@@ -28,7 +28,7 @@ module.exports = {
2828
};
2929
```
3030

31-
3. Change the builder in `angular.json` to `"@angular-builders/custom-webpack:browser` and configure it correctly to use our new webpack config.
31+
3. Change the builder in `angular.json` to `"@angular-builders/custom-webpack:browser"` and configure it correctly to use our new webpack config.
3232

3333
> angular.json
3434
```json

CONTRIBUTING.md

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# Contributing to Plotly.js
22

33
Thanks for your interest in contributing to Plotly.js! We are actively looking for
4-
diverse contributors, with diverse background and skills.
4+
diverse contributors, with diverse backgrounds and skills.
55

66
This document outlines the general way that changes get made to this library and by whom,
77
and then provides specific technical information about how to set up a development
@@ -79,12 +79,12 @@ We use the following [labels](https://github.com/plotly/plotly.js/labels) to tra
7979
- git
8080
- [node.js](https://nodejs.org/en/). We recommend using node.js v18.x.
8181
Upgrading and managing node versions can be easily done using
82-
[`nvm`](https://github.com/creationix/nvm) or its Windows alternatives.
82+
[`nvm`](https://github.com/nvm-sh/nvm) or its Windows alternatives.
8383
- [`npm`](https://www.npmjs.com/) v10.x and up to ensure that the
8484
[`package-lock.json`](https://docs.npmjs.com/files/package-lock.json) file is
8585
used and updated correctly.
8686
- [`python3`](https://www.python.org/downloads/)
87-
Note: for M1 mac users specifically, you might need to install some [extra dependencies](https://github.com/Automattic/node-canvas/issues/1733#issuecomment-761703018).
87+
Note: For M1 Mac users specifically, you might need to install some [extra dependencies](https://github.com/Automattic/node-canvas/issues/1733#issuecomment-761703018).
8888

8989
#### Step 1: Fork the plotly.js repository, clone your fork and step into it
9090

@@ -332,7 +332,7 @@ This will produce the following plot, and say you want to simulate a selection p
332332
- Sources files are in `src/`
333333
- Build and repo management scripts are in `tasks/`
334334
- All tasks can be run using [`npm run-script`](https://docs.npmjs.com/cli/run-script)
335-
- Tests are `test/`, they are partitioned into `image` and `jasmine` tests
335+
- Tests are in `test/`; they are partitioned into `image` and `jasmine` tests
336336
- Test dashboard and image viewer code is in `devtools/`
337337
- Built files are in `build/` (the files in here are git-ignored, except for `plotcss.js`)
338338

@@ -384,10 +384,10 @@ Other methods used by some trace modules:
384384
selections.
385385
- `_module.convert`: Sometimes separated from `_module.plot` or `_module.calc` to convert the
386386
plotly.js settings to another framework e.g. to `gl-plot3d` for `gl3d` traces, to
387-
`mapbox-gl` from `mapbox` traces. This split can make the logic easier to test.
387+
`mapbox-gl` for `mapbox` traces. This split can make the logic easier to test.
388388
If you make a `convert`, you should call it from either `calc` or `plot`.
389389

390390
## Coding style
391391

392-
Check if ok, with `npm run lint`
392+
Check if OK with `npm run lint`
393393

CUSTOM_BUNDLE.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
# Custom bundle
2-
You can simply make custom bundles yourself, if none of the [distributed packages](https://github.com/plotly/plotly.js/blob/master/dist/README.md) meet your needs, or you want to make a more optimized bundle file with/without specific traces.
2+
You can easily make custom bundles yourself if none of the [distributed packages](https://github.com/plotly/plotly.js/blob/master/dist/README.md) meet your needs, or if you want to make a more optimized bundle file with/without specific traces.
33

44
Make sure you have the versions of node/npm that's recommended:
55
- plotly.js before 2.5: Node 12/npm 6
@@ -15,19 +15,19 @@ Clone plotly.js, where the <version> is one of [these](https://github.com/plotly
1515
git clone --branch <version> https://github.com/plotly/plotly.js.git
1616
```
1717

18-
Note: If you've already cloned plotly.js, then could switch to another version with:
18+
Note: If you've already cloned plotly.js, then you can switch to another version with:
1919
```sh
2020
git fetch
2121
git checkout <version>
2222
```
2323

24-
Move to plotly.js folder then install plotly.js dependencies:
24+
Move to the `plotly.js` directory, then install its dependencies:
2525
```sh
2626
cd plotly.js
2727
npm i
2828
```
2929

30-
By default all traces are included in the bundle if you simply run:
30+
By default, all traces are included in the bundle if you simply run:
3131
```sh
3232
npm run custom-bundle
3333
```
@@ -56,7 +56,7 @@ npm run custom-bundle -- --unminified
5656
```
5757

5858
# Example illustrating use of different options together
59-
To create an unminified custom bundle named `myScatters` including `scatter`, `scattergl` and `scatter3d` traces:
59+
To create an unminified custom bundle named `myScatters` including `scatter`, `scattergl`, and `scatter3d` traces:
6060
```sh
6161
npm run custom-bundle -- \
6262
--unminified \

README.md

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
[![circle ci](https://circleci.com/gh/plotly/plotly.js.svg?style=shield)](https://circleci.com/gh/plotly/plotly.js)
55
[![MIT License](https://img.shields.io/badge/License-MIT-brightgreen.svg)](https://github.com/plotly/plotly.js/blob/master/LICENSE)
66

7-
[Plotly.js](https://plotly.com/javascript) is a standalone Javascript data visualization library, and it also powers the Python and R modules named `plotly` in those respective ecosystems (referred to as [Plotly.py](https://plotly.com/python) and [Plotly.R](http://plotly.com/r)).
7+
[Plotly.js](https://plotly.com/javascript) is a standalone JavaScript data visualization library, and it also powers the Python and R modules named `plotly` in those respective ecosystems (referred to as [Plotly.py](https://plotly.com/python) and [Plotly.R](http://plotly.com/r)).
88

99
Plotly.js can be used to produce dozens of chart types and visualizations, including statistical charts, 3D graphs, scientific charts, SVG and tile maps, financial charts and more.
1010

@@ -58,7 +58,7 @@ You may also consider using [`plotly.js-dist`](https://www.npmjs.com/package/plo
5858
## Load via script tag
5959

6060
### The script HTML element
61-
> In the examples below `Plotly` object is added to the window scope by `script`. The `newPlot` method is then used to draw an interactive figure as described by `data` and `layout` into the desired `div` here named `gd`. As demonstrated in the example above basic knowledge of `html` and [JSON](https://en.wikipedia.org/wiki/JSON) syntax is enough to get started i.e. with/without JavaScript! To learn and build more with plotly.js please visit [plotly.js documentation](https://plotly.com/javascript).
61+
> In the examples below, the `Plotly` object is added to the window scope by the `script` tag. The `newPlot` method is then used to draw an interactive figure as described by `data` and `layout` into the desired `div` here named `gd`. As demonstrated in the example above, basic knowledge of HTML and [JSON](https://en.wikipedia.org/wiki/JSON) syntax is enough to get started, i.e., with or without JavaScript! To learn and build more with plotly.js, please visit the [plotly.js documentation](https://plotly.com/javascript).
6262
6363
```html
6464
<head>
@@ -76,7 +76,7 @@ You may also consider using [`plotly.js-dist`](https://www.npmjs.com/package/plo
7676
</body>
7777
```
7878

79-
Alternatively you may consider using [native ES6 import](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Guide/Modules) in the script tag.
79+
Alternatively, you may consider using [native ES6 import](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Guide/Modules) in the script tag.
8080
```html
8181
<script type="module">
8282
import "https://cdn.plot.ly/plotly-3.4.0.min.js"
@@ -95,7 +95,7 @@ While non-minified source files may contain characters outside UTF-8, it is reco
9595
> Please note that as of v2 the "plotly-latest" outputs (e.g. https://cdn.plot.ly/plotly-latest.min.js) will no longer be updated on the CDN, and will stay at the last v1 patch v1.58.5. Therefore, to use the CDN with plotly.js v2 and higher, you must specify an exact plotly.js version.
9696
9797
### MathJax
98-
You could load either version two or version three of MathJax files, for example:
98+
You can load either version two or version three of MathJax files. For example:
9999
```html
100100
<script src="https://cdnjs.cloudflare.com/ajax/libs/mathjax/2.7.5/MathJax.js?config=TeX-AMS-MML_SVG.js"></script>
101101
```
@@ -108,15 +108,15 @@ You could load either version two or version three of MathJax files, for example
108108
Please refer to `devtools/test_dashboard/index-mathjax3chtml.html` to see an example.
109109

110110
### Need to have several WebGL graphs on a page?
111-
You may simply load [virtual-webgl](https://github.com/greggman/virtual-webgl) script for WebGL 1 (not WebGL 2) before loading other scripts.
111+
You may simply load the [virtual-webgl](https://github.com/greggman/virtual-webgl) script for WebGL 1 (not WebGL 2) before loading other scripts.
112112
```html
113113
<script src="https://unpkg.com/virtual-webgl@1.0.6/src/virtual-webgl.js"></script>
114114
```
115115

116116
## Bundles
117117
There are two kinds of plotly.js bundles:
118118
1. Complete and partial official bundles that are distributed to `npm` and the `CDN`, described in [the dist README](https://github.com/plotly/plotly.js/blob/master/dist/README.md).
119-
2. Custom bundles you can create yourself to optimize the size of bundle depending on your needs. Please visit [CUSTOM_BUNDLE](https://github.com/plotly/plotly.js/blob/master/CUSTOM_BUNDLE.md) for more information.
119+
2. Custom bundles you can create yourself to optimize the size of the bundle depending on your needs. Please visit [CUSTOM_BUNDLE](https://github.com/plotly/plotly.js/blob/master/CUSTOM_BUNDLE.md) for more information.
120120

121121
---
122122
## Alternative ways to load and build plotly.js
@@ -133,7 +133,7 @@ For more info about contributing to Plotly documentation, please read through [c
133133
---
134134
## Bugs and feature requests
135135

136-
Have a bug or a feature request? Please [open a Github issue](https://github.com/plotly/plotly.js/issues/new) keeping in mind the [issue guidelines](https://github.com/plotly/plotly.js/blob/master/.github/ISSUE_TEMPLATE.md). You may also want to read about [how changes get made to Plotly.js](https://github.com/plotly/plotly.js/blob/master/CONTRIBUTING.md)
136+
Have a bug or a feature request? Please [open a Github issue](https://github.com/plotly/plotly.js/issues/new) keeping in mind the [issue guidelines](https://github.com/plotly/plotly.js/blob/master/.github/ISSUE_TEMPLATE.md). You may also want to read about [how changes get made to Plotly.js](https://github.com/plotly/plotly.js/blob/master/CONTRIBUTING.md).
137137

138138
---
139139
## Contributing

SECURITY.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ The open source plotly.js library is provided "AS IS", with no security guarante
66
In the 1.x releases of plotly.js, we attempt to protect against XSS attacks (and similar issues) resulting from
77
untrusted data being graphed by plotly.js. However, XSS or other issues may still exist.
88

9-
Note that the typical use case for plotly.js is for visualizing data from trusted sources. For example if you use plotly.js to add a dashboard to your site and you control all the input data that's sent to plotly.js, you are not dependent on plotly.js for XSS protection.
9+
Note that the typical use case for plotly.js is for visualizing data from trusted sources. For example, if you use plotly.js to add a dashboard to your site and you control all the input data that's sent to plotly.js, you are not dependent on plotly.js for XSS protection.
1010

1111
If you require a higher degree of assurance, please consider purchasing our
1212
[Plotly On-Premise](https://plotly.com/get-pricing/) product, or [contact the Plotly sales team](mailto:sales@plotly.com)
@@ -23,7 +23,7 @@ In some cases, we offer monetary compensation (bounties) for reports of security
2323

2424
## Release Process
2525

26-
plotly.js security fixes are normally released as "patch" releases on top of the current plotly.js version. For example if the current plotly.js version is 1.14.0 and we fix a security issue, we will release 1.14.1 with the fix. Alternatively, security fixes may be made as part of a major or minor plotly.js release, if the fix coincides with our normal release cycle. For example if the current plotly.js version is 1.14.0, we may release version 1.15.0 with the fix instead of 1.14.1.
26+
plotly.js security fixes are normally released as "patch" releases on top of the current plotly.js version. For example, if the current plotly.js version is 1.14.0 and we fix a security issue, we will release 1.14.1 with the fix. Alternatively, security fixes may be made as part of a major or minor plotly.js release, if the fix coincides with our normal release cycle. For example, if the current plotly.js version is 1.14.0, we may release version 1.15.0 with the fix instead of 1.14.1.
2727

2828
Security fixes are backported to older versions of plotly.js as required by paying Plotly On-Premise or Plotly Cloud customers. These fixes are released as "patch" releases, and are made available to the community once affected customers have upgraded. We also accept backports to older versions contributed by community members.
2929

test/plot-schema.json

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -124,6 +124,11 @@
124124
false
125125
]
126126
},
127+
"displayNotifier": {
128+
"description": "Determines whether or not notifier is displayed.",
129+
"dflt": true,
130+
"valType": "boolean"
131+
},
127132
"doubleClick": {
128133
"description": "Sets the double click interaction mode. Has an effect only in cartesian plots. If *false*, double click is disable. If *reset*, double click resets the axis ranges to their initial values. If *autosize*, double click set the axis ranges to their autorange values. If *reset+autosize*, the odd double clicks resets the axis ranges to their initial values and even double clicks set the axis ranges to their autorange values.",
129134
"dflt": "reset+autosize",

0 commit comments

Comments
 (0)