Remove html entity decoding from convertToSVG

Jody McIntyre · Jody McIntyre · commit 6a66569f767a · 2016-08-01T16:48:55.000-04:00
This is unnecessary and imposes a performance hit on long strings.
diff --git a/src/lib/svg_text_utils.js b/src/lib/svg_text_utils.js
@@ -252,8 +252,7 @@ function encodeForHTML(_str) {
 }
 
 function convertToSVG(_str) {
-    var htmlEntitiesDecoded = Plotly.util.html_entity_decode(_str);
-    var result = htmlEntitiesDecoded
+    var result = _str
         .split(/(<[^<>]*>)/).map(function(d) {
             var match = d.match(/<(\/?)([^ >]*)\s*(.*)>/i),
                 tag = match && match[2].toLowerCase(),

Original file line number	Diff line number	Diff line change
`@@ -252,8 +252,7 @@ function encodeForHTML(_str) {`
`252`	`252`	`}`
`253`	`253`
`254`	`254`	`function convertToSVG(_str) {`
`255`		`- var htmlEntitiesDecoded = Plotly.util.html_entity_decode(_str);`
`256`		`- var result = htmlEntitiesDecoded`
	`255`	`+ var result = _str`
`257`	`256`	`.split(/(<[^<>]*>)/).map(function(d) {`
`258`	`257`	`var match = d.match(/<(\/?)([^ >])\s(.*)>/i),`
`259`	`258`	`tag = match && match[2].toLowerCase(),`