Skip to content

Commit f8dfb39

Browse files
authored
Merge branch 'plotly:master' into multi-axis-reference-shapes
2 parents d940675 + a6a10f9 commit f8dfb39

19 files changed

+93
-2
lines changed

.circleci/config.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -148,6 +148,7 @@ jobs:
148148
install-firefox: false
149149
install-geckodriver: false
150150
install-chrome: true
151+
chrome-version: "143.0.7499.192" # TEMPORARY pin until WebGL issues with 144 are resolved
151152
- attach_workspace:
152153
at: ~/
153154
- run:

draftlogs/7676_fix.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
- Fix out of bounds index during scattergl animation trace type [[#7676](https://github.com/plotly/plotly.js/pull/7676)], with thanks to @BJohnBraddock for the contribution!

src/traces/scattergl/plot.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -263,8 +263,8 @@ var exports = module.exports = function plot(gd, subplot, cdata) {
263263
var isSelectMode = selectMode(dragmode);
264264
var clickSelectEnabled = fullLayout.clickmode.indexOf('select') > -1;
265265

266-
for(i = 0; i < count; i++) {
267-
var cd0 = cdata[i][0];
266+
for (const [cd0] of cdata) {
267+
if (!cd0) continue;
268268
var trace = cd0.trace;
269269
var stash = cd0.t;
270270
var index = stash.index;

test/image/baselines/map_0.png

14 Bytes
Loading
-159 Bytes
Loading
-7 Bytes
Loading
45 Bytes
Loading
12 Bytes
Loading
10 Bytes
Loading
-13 Bytes
Loading

0 commit comments

Comments
 (0)