From 3a67416ff6a0fa3187a70396824bfa3acf1d6a07 Mon Sep 17 00:00:00 2001 From: Emily KL <4672118+emilykl@users.noreply.github.com> Date: Wed, 1 Apr 2026 15:44:41 -0400 Subject: [PATCH 1/9] bump chrome to v136 in ci --- .circleci/config.yml | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index 39633e96386..9c373616b26 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -44,7 +44,7 @@ jobs: install_firefox: false install_geckodriver: false install_chrome: true - chrome_version: "135.0.7049.95" + chrome_version: "136.0.7103.113" - attach_workspace: at: ~/ - run: @@ -83,7 +83,7 @@ jobs: install_firefox: false install_geckodriver: false install_chrome: true - chrome_version: "135.0.7049.95" + chrome_version: "136.0.7103.113" - attach_workspace: at: ~/ - run: @@ -105,7 +105,7 @@ jobs: install_firefox: false install_geckodriver: false install_chrome: true - chrome_version: "135.0.7049.95" + chrome_version: "136.0.7103.113" - attach_workspace: at: ~/ - run: @@ -127,7 +127,7 @@ jobs: install_firefox: false install_geckodriver: false install_chrome: true - chrome_version: "135.0.7049.95" + chrome_version: "136.0.7103.113" - attach_workspace: at: ~/ - run: @@ -169,7 +169,7 @@ jobs: install_firefox: false install_geckodriver: false install_chrome: true - chrome_version: "135.0.7049.95" + chrome_version: "136.0.7103.113" - attach_workspace: at: ~/ - run: @@ -190,7 +190,7 @@ jobs: install_firefox: false install_geckodriver: false install_chrome: true - chrome_version: "135.0.7049.95" + chrome_version: "136.0.7103.113" - attach_workspace: at: ~/ - run: From 56b1c877a82ff082b6c406e3b2286122b7e5ee8a Mon Sep 17 00:00:00 2001 From: Emily KL <4672118+emilykl@users.noreply.github.com> Date: Thu, 2 Apr 2026 11:33:02 -0400 Subject: [PATCH 2/9] use getBBox instead of getBoundingClientRect in assertPlotSize --- test/jasmine/assets/custom_assertions.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/jasmine/assets/custom_assertions.js b/test/jasmine/assets/custom_assertions.js index 9dc24ecbe75..a19c8485484 100644 --- a/test/jasmine/assets/custom_assertions.js +++ b/test/jasmine/assets/custom_assertions.js @@ -295,7 +295,7 @@ exports.assertPlotSize = function(opts, msg) { var widthLessThan = opts.widthLessThan; var heightLessThan = opts.heightLessThan; - var plotBB = d3Select('.plotclip > rect').node().getBoundingClientRect(); + var plotBB = d3Select('.plotclip > rect').node().getBBox(); var actualWidth = plotBB.width; var actualHeight = plotBB.height; From f1381194f19497e130ee144aabf1c68fdaa66841 Mon Sep 17 00:00:00 2001 From: Emily KL <4672118+emilykl@users.noreply.github.com> Date: Thu, 2 Apr 2026 11:46:43 -0400 Subject: [PATCH 3/9] add map_layers mock to blacklist due to error --- test/image/compare_pixels_test.js | 1 + test/image/make_baseline.py | 1 + 2 files changed, 2 insertions(+) diff --git a/test/image/compare_pixels_test.js b/test/image/compare_pixels_test.js index 656ce846532..574e5edf51f 100644 --- a/test/image/compare_pixels_test.js +++ b/test/image/compare_pixels_test.js @@ -67,6 +67,7 @@ var blacklist = [ 'map_scattercluster', 'map_fonts-supported-open-sans', 'map_fonts-supported-open-sans-weight', + 'map_layers', ]; if(virtualWebgl) { diff --git a/test/image/make_baseline.py b/test/image/make_baseline.py index 6b29e47e09f..01dc836da76 100644 --- a/test/image/make_baseline.py +++ b/test/image/make_baseline.py @@ -71,6 +71,7 @@ 'map_scattercluster', 'map_fonts-supported-open-sans', 'map_fonts-supported-open-sans-weight', + 'map_layers', ] allNames = [a for a in allNames if a not in blacklist] From 29fd7ca419aab68281989f2fcc0e5dd143a7ef83 Mon Sep 17 00:00:00 2001 From: Emily KL <4672118+emilykl@users.noreply.github.com> Date: Thu, 2 Apr 2026 13:28:57 -0400 Subject: [PATCH 4/9] add some debugging statements --- test/jasmine/assets/get_node_coords.js | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/test/jasmine/assets/get_node_coords.js b/test/jasmine/assets/get_node_coords.js index 9bc9f86604d..f564db18f16 100644 --- a/test/jasmine/assets/get_node_coords.js +++ b/test/jasmine/assets/get_node_coords.js @@ -5,7 +5,13 @@ */ module.exports = function(node, edge) { edge = edge || ''; + console.log('getNodeCoords()'); + console.log(' node.outerHTML', node.outerHTML); + console.log(' document contains node?', document.body.contains(node)); var bbox = node.getBoundingClientRect(); + var getbbox = node.getBBox(); + console.log(' bounding client rect', {x: bbox.x, y: bbox.y, width: bbox.width, height: bbox.height}); + console.log(' bounding box', {x: getbbox.x, y: getbbox.y, width: getbbox.width, height: getbbox.height}); var x, y; if(edge.indexOf('n') !== -1) y = bbox.top; @@ -16,5 +22,7 @@ module.exports = function(node, edge) { else if(edge.indexOf('e') !== -1) x = bbox.right; else x = (bbox.left + bbox.right) / 2; + console.log(' returning coords:', {x: x, y: y}); + return {x: x, y: y}; }; From e91c37a9cf06ea0cc4b7a19e9da9f451b1646121 Mon Sep 17 00:00:00 2001 From: Emily KL <4672118+emilykl@users.noreply.github.com> Date: Thu, 2 Apr 2026 14:13:36 -0400 Subject: [PATCH 5/9] revert debug statements --- test/jasmine/assets/get_node_coords.js | 8 -------- 1 file changed, 8 deletions(-) diff --git a/test/jasmine/assets/get_node_coords.js b/test/jasmine/assets/get_node_coords.js index f564db18f16..9bc9f86604d 100644 --- a/test/jasmine/assets/get_node_coords.js +++ b/test/jasmine/assets/get_node_coords.js @@ -5,13 +5,7 @@ */ module.exports = function(node, edge) { edge = edge || ''; - console.log('getNodeCoords()'); - console.log(' node.outerHTML', node.outerHTML); - console.log(' document contains node?', document.body.contains(node)); var bbox = node.getBoundingClientRect(); - var getbbox = node.getBBox(); - console.log(' bounding client rect', {x: bbox.x, y: bbox.y, width: bbox.width, height: bbox.height}); - console.log(' bounding box', {x: getbbox.x, y: getbbox.y, width: getbbox.width, height: getbbox.height}); var x, y; if(edge.indexOf('n') !== -1) y = bbox.top; @@ -22,7 +16,5 @@ module.exports = function(node, edge) { else if(edge.indexOf('e') !== -1) x = bbox.right; else x = (bbox.left + bbox.right) / 2; - console.log(' returning coords:', {x: x, y: y}); - return {x: x, y: y}; }; From 13e51297cf1b45f77bc54c94b7aaa356a7be4587 Mon Sep 17 00:00:00 2001 From: Emily KL <4672118+emilykl@users.noreply.github.com> Date: Thu, 2 Apr 2026 15:30:15 -0400 Subject: [PATCH 6/9] adjust values for geo test --- test/jasmine/tests/geo_test.js | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/test/jasmine/tests/geo_test.js b/test/jasmine/tests/geo_test.js index 690c91836e2..83d0f92a4c2 100644 --- a/test/jasmine/tests/geo_test.js +++ b/test/jasmine/tests/geo_test.js @@ -2588,8 +2588,8 @@ describe('Test geo zoom/pan/drag interactions:', function() { var center = geoLayout.center; var scale = geoLayout.projection.scale; - expect(center.lon).toBeCloseTo(attr[0][0], 0.5, msg + 'center.lon'); - expect(center.lat).toBeCloseTo(attr[0][1], 0.5, msg + 'center.lat'); + expect(center.lon).toBeCloseTo(attr[0][0], 0, msg + 'center.lon'); + expect(center.lat).toBeCloseTo(attr[0][1], 0, msg + 'center.lat'); expect(scale).toBeCloseTo(attr[1], 1, msg + 'zoom'); // albersUsa projection does not have a center() method @@ -2608,7 +2608,7 @@ describe('Test geo zoom/pan/drag interactions:', function() { _assert('base', [ [-96.6, 38.7], 1, ], [ - [416, 309], 738.5 + [410, 329], 738.5 ], undefined); return drag({path: [[250, 250], [200, 200]], noCover: true}); }) @@ -2616,7 +2616,7 @@ describe('Test geo zoom/pan/drag interactions:', function() { _assert('after NW-SE drag', [ [-91.8, 34.8], 1, ], [ - [366, 259], 738.5 + [366, 279], 738.5 ], [ 'geo.center.lon', 'geo.center.lon' ]); @@ -2626,7 +2626,7 @@ describe('Test geo zoom/pan/drag interactions:', function() { _assert('after scroll', [ [-94.5, 35.0], 1.3 ], [ - [387.1, 245.9], 974.4 + [380, 273], 974.4 ], [ 'geo.center.lon', 'geo.center.lon', 'geo.projection.scale' ]); @@ -2637,7 +2637,7 @@ describe('Test geo zoom/pan/drag interactions:', function() { [-94.5, 35.0], 1.3 ], [ // new center values are reflected in translate() - [387.1, 245.9], 974.4 + [380, 273], 974.4 ], [ 'geo.showlakes' ]); @@ -2647,7 +2647,7 @@ describe('Test geo zoom/pan/drag interactions:', function() { _assert('after double click', [ [-96.6, 38.7], 1, ], [ - [416, 309], 738.5 + [416, 329], 738.5 ], 'dblclick'); }) .then(done, done.fail); From 4c97aa6a12b13b457b180cb429ab242b3c6d134e Mon Sep 17 00:00:00 2001 From: Emily KL <4672118+emilykl@users.noreply.github.com> Date: Thu, 2 Apr 2026 15:46:51 -0400 Subject: [PATCH 7/9] try adjust hover position --- test/jasmine/tests/volume_test.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/jasmine/tests/volume_test.js b/test/jasmine/tests/volume_test.js index 48907f774f9..78ec3c8d29b 100644 --- a/test/jasmine/tests/volume_test.js +++ b/test/jasmine/tests/volume_test.js @@ -336,7 +336,7 @@ describe('Test volume', function() { } function _hover4() { - mouseEvent('mouseover', 150, 300); + mouseEvent('mouseover', 140, 300); return delay(20)(); } From 3c69d8471a03e0c6f657c88edb77bcdd8f2f73a8 Mon Sep 17 00:00:00 2001 From: Emily KL <4672118+emilykl@users.noreply.github.com> Date: Thu, 2 Apr 2026 15:58:51 -0400 Subject: [PATCH 8/9] try adjust values for volume test 2 --- test/jasmine/tests/volume_test.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/jasmine/tests/volume_test.js b/test/jasmine/tests/volume_test.js index 78ec3c8d29b..55c9023b0b0 100644 --- a/test/jasmine/tests/volume_test.js +++ b/test/jasmine/tests/volume_test.js @@ -336,7 +336,7 @@ describe('Test volume', function() { } function _hover4() { - mouseEvent('mouseover', 140, 300); + mouseEvent('mouseover', 130, 300); return delay(20)(); } From 88cf4ebe845d7772adaa8ebb53ac19dea581b671 Mon Sep 17 00:00:00 2001 From: Emily KL <4672118+emilykl@users.noreply.github.com> Date: Thu, 2 Apr 2026 16:12:15 -0400 Subject: [PATCH 9/9] Revert "try adjust values for volume test 2" This reverts commit 3c69d8471a03e0c6f657c88edb77bcdd8f2f73a8. --- test/jasmine/tests/volume_test.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/jasmine/tests/volume_test.js b/test/jasmine/tests/volume_test.js index 55c9023b0b0..78ec3c8d29b 100644 --- a/test/jasmine/tests/volume_test.js +++ b/test/jasmine/tests/volume_test.js @@ -336,7 +336,7 @@ describe('Test volume', function() { } function _hover4() { - mouseEvent('mouseover', 130, 300); + mouseEvent('mouseover', 140, 300); return delay(20)(); }