Skip to content

Commit 892630e

Browse files
committed
add step to check chrome install (fail fast)
1 parent a53faab commit 892630e

File tree

4 files changed

+7
-4
lines changed

4 files changed

+7
-4
lines changed

.github/workflows/ci-builds.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ name: CI Builds
33
on:
44
push:
55
pull_request:
6+
types: [opened, reopened]
67

78
jobs:
89
plotlyjs-dev-build:

.github/workflows/ci-format.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ name: CI Formatting
33
on:
44
push:
55
pull_request:
6+
types: [opened, reopened]
67

78
jobs:
89
check-code-formatting:

.github/workflows/ci-percy.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ name: CI Percy
33
on:
44
push:
55
pull_request:
6+
types: [opened, reopened]
67
workflow_dispatch:
78

89
jobs:

.github/workflows/ci-tests.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ name: CI Tests
33
on:
44
push:
55
pull_request:
6+
types: [opened, reopened]
67

78
jobs:
89
test-core:
@@ -18,10 +19,6 @@ jobs:
1819
uses: actions/setup-python@v5
1920
with:
2021
python-version: ${{ matrix.python-version }}
21-
- name: Set up Chrome
22-
uses: browser-actions/setup-chrome@v2.1.1
23-
with:
24-
install-chromedriver: true
2522
- name: Install dependencies
2623
run: |
2724
curl -LsSf https://astral.sh/uv/install.sh | sh
@@ -56,6 +53,9 @@ jobs:
5653
uses: browser-actions/setup-chrome@v2.1.1
5754
with:
5855
install-chromedriver: true
56+
- name: Check whether we can access Chrome from Python
57+
run: |
58+
python -c "import webbrowser; webbrowser.get()"
5959
- name: Install dependencies
6060
run: |
6161
curl -LsSf https://astral.sh/uv/install.sh | sh

0 commit comments

Comments
 (0)