Skip to content

Commit 504dd25

Browse files
committed
Moved title bar margin option into "Footnotes" submenu.
Moved header rect modification from function LVDocView::drawPageTo() to LVDocView::getPageHeaderRectangle(), to excude text intersection(imposition) in title bar.
1 parent 31eb79a commit 504dd25

4 files changed

Lines changed: 6 additions & 8 deletions

File tree

android/res/values-ru/strings.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@
8989
<string name="options_page_margin_right">Правый отступ</string>
9090
<string name="options_page_margin_top">Верхний отступ</string>
9191
<string name="options_page_margin_bottom">Нижний отступ</string>
92-
<string name="options_rounded_corners_margin">Отступы в заголовке (для скругленных краев)</string>
92+
<string name="options_rounded_corners_margin">Отступ (для устройств со скругленными углами)</string>
9393
<string name="options_view_mode">Режим просмотра</string>
9494
<string name="options_view_mode_pages">Страницы</string>
9595
<string name="options_view_mode_scroll">Свиток</string>

android/res/values/strings.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@
9494
<string name="options_page_margin_right">Right margin</string>
9595
<string name="options_page_margin_top">Top margin</string>
9696
<string name="options_page_margin_bottom">Bottom margin</string>
97-
<string name="options_rounded_corners_margin">Header margins (for rounded corners)</string>
97+
<string name="options_rounded_corners_margin">Margin (for devices with rounded corners)</string>
9898
<string name="options_view_mode">View mode</string>
9999
<string name="options_view_mode_pages">Pages</string>
100100
<string name="options_view_mode_scroll">Scroll</string>

android/src/org/coolreader/crengine/OptionsDialog.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -759,6 +759,7 @@ public void onSelect() {
759759
BaseDialog dlg = new BaseDialog(mActivity, label, false, false);
760760
OptionsListView listView = new OptionsListView(getContext());
761761
listView.add(new ListOption(mOwner, getString(R.string.options_page_show_titlebar), PROP_STATUS_LOCATION).add(mStatusPositions, mStatusPositionsTitles).setDefaultValue("1"));
762+
listView.add(new ListOption(mOwner, getString(R.string.options_rounded_corners_margin), PROP_ROUNDED_CORNERS_MARGIN).add(mRoundedCornersMargins).setDefaultValue("0"));
762763
listView.add(new ListOption(mOwner, getString(R.string.options_page_titlebar_font_face), PROP_STATUS_FONT_FACE).add(mFontFaces).setDefaultValue(mFontFaces[0]).setIconIdByAttr(R.attr.cr3_option_font_face_drawable, R.drawable.cr3_option_font_face));
763764
listView.add(new ListOption(mOwner, getString(R.string.options_page_titlebar_font_size), PROP_STATUS_FONT_SIZE).add(filterFontSizes(mStatusFontSizes)).setDefaultValue("18").setIconIdByAttr(R.attr.cr3_option_font_size_drawable, R.drawable.cr3_option_font_size));
764765
listView.add(new ColorOption(mOwner, getString(R.string.options_page_titlebar_font_color), PROP_STATUS_FONT_COLOR, 0x000000));
@@ -1955,7 +1956,6 @@ private void setupReaderOptions()
19551956
mOptionsPage.add(new ListOption(this, getString(R.string.options_page_margin_right), PROP_PAGE_MARGIN_RIGHT).add(mMargins).setDefaultValue("5").setIconIdByAttr(R.attr.cr3_option_text_margin_right_drawable, R.drawable.cr3_option_text_margin_right));
19561957
mOptionsPage.add(new ListOption(this, getString(R.string.options_page_margin_top), PROP_PAGE_MARGIN_TOP).add(mMargins).setDefaultValue("5").setIconIdByAttr(R.attr.cr3_option_text_margin_top_drawable, R.drawable.cr3_option_text_margin_top));
19571958
mOptionsPage.add(new ListOption(this, getString(R.string.options_page_margin_bottom), PROP_PAGE_MARGIN_BOTTOM).add(mMargins).setDefaultValue("5").setIconIdByAttr(R.attr.cr3_option_text_margin_bottom_drawable, R.drawable.cr3_option_text_margin_bottom));
1958-
mOptionsPage.add(new ListOption(this, getString(R.string.options_rounded_corners_margin), PROP_ROUNDED_CORNERS_MARGIN).add(mRoundedCornersMargins).setDefaultValue("0"));
19591959

19601960
mOptionsControls = new OptionsListView(getContext());
19611961
mOptionsControls.add(new KeyMapOption(this, getString(R.string.options_app_key_actions)).setIconIdByAttr(R.attr.cr3_option_controls_keys_drawable, R.drawable.cr3_option_controls_keys));

crengine/src/lvdocview.cpp

100755100644
Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1245,10 +1245,11 @@ void LVDocView::getPageHeaderRectangle(int pageIndex, lvRect & headerRc) {
12451245
headerRc.bottom = 0;
12461246
} else {
12471247
int h = getPageHeaderHeight();
1248+
int propHeaderMargin = m_props->getIntDef(PROP_ROUNDED_CORNERS_MARGIN, 0);
12481249
headerRc.bottom = headerRc.top + h;
12491250
headerRc.top += HEADER_MARGIN;
1250-
headerRc.left += HEADER_MARGIN;
1251-
headerRc.right -= HEADER_MARGIN;
1251+
headerRc.left += HEADER_MARGIN + propHeaderMargin;
1252+
headerRc.right -= HEADER_MARGIN + propHeaderMargin;
12521253
}
12531254
}
12541255

@@ -1603,9 +1604,6 @@ void LVDocView::drawPageHeader(LVDrawBuf * drawbuf, const lvRect & headerRc,
16031604
drawbuf->SetClipRect(&hrc);
16041605
bool drawGauge = true;
16051606
lvRect info = headerRc;
1606-
info.left = info.left + m_props->getIntDef(PROP_ROUNDED_CORNERS_MARGIN, 0);
1607-
info.right = info.right - m_props->getIntDef(PROP_ROUNDED_CORNERS_MARGIN, 0);;
1608-
16091607
// if ( m_statusColor!=0xFF000000 ) {
16101608
// CRLog::trace("Status color = %06x, textColor=%06x", m_statusColor, getTextColor());
16111609
// } else {

0 commit comments

Comments
 (0)