Skip to content

Commit 23abf07

Browse files
committed
Collapsed the two-method split (build + _build_for_component) into a single method, eliminating the intermediate dict allocation and set() wrapping.
1 parent 7b76e67 commit 23abf07

1 file changed

Lines changed: 3 additions & 15 deletions

File tree

plugboard/connector/event_connector_spec_builder.py

Lines changed: 3 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -23,23 +23,11 @@ def build(components: _t.Iterable[Component]) -> dict[str, ConnectorSpec]:
2323
"""Returns mapping of connector specs for events handled by components."""
2424
evt_conn_map: dict[str, ConnectorSpec] = {}
2525
for component in components:
26-
comp_evt_conn_map = EventConnectorSpecBuilder._build_for_component(
27-
evt_conn_map, component
28-
)
29-
evt_conn_map.update(comp_evt_conn_map)
26+
for evt in component.io.input_events + component.io.output_events:
27+
if evt.type not in evt_conn_map:
28+
evt_conn_map[evt.type] = EventConnectorSpecBuilder._build_for_event(evt.type)
3029
return evt_conn_map
3130

32-
@staticmethod
33-
def _build_for_component(
34-
evt_conn_map: dict[str, ConnectorSpec], component: Component
35-
) -> dict[str, ConnectorSpec]:
36-
component_evts = set(component.io.input_events + component.io.output_events)
37-
return {
38-
evt.type: EventConnectorSpecBuilder._build_for_event(evt.type)
39-
for evt in component_evts
40-
if evt.type not in evt_conn_map
41-
}
42-
4331
@staticmethod
4432
def _build_for_event(evt_type: str) -> ConnectorSpec:
4533
evt_type_safe = Event.safe_type(evt_type)

0 commit comments

Comments
 (0)