-
Notifications
You must be signed in to change notification settings - Fork 0
fix: support reusing field-input components in event-driven flows #249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Copilot
wants to merge
27
commits into
main
Choose a base branch
from
copilot/feat-improve-component-reusability
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 8 commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
b58cb93
Initial plan
Copilot 2536193
fix: support reusing field-input components in event-driven flows
Copilot e7a822a
chore: address review feedback on event-driven reuse fix
Copilot 5e39023
docs: clarify event-driven reuse shutdown handling
Copilot 544d5c8
docs: clarify event-driven reuse test intent
Copilot b3c4e16
refactor: expose connected input state on io controller
Copilot e4047cb
refactor: reuse connected input property internally
Copilot b442ee0
refactor: simplify connected field input checks
Copilot 21b8ea4
fix: Modifies DataWriter logic to only append new data
chrisk314 f763d86
refactor: Separates field data tracker reset into new method for easi…
chrisk314 675e8de
refactor: Adapts DataWriter for trickling input data
chrisk314 7fe735b
refactor: Rework DataWriter logic
chrisk314 5fad405
fixup! refactor: Rework DataWriter logic
chrisk314 8ca6298
test: Adds test for staggered event driven data arrival
chrisk314 5378b4c
Merge branch 'main' into copilot/feat-improve-component-reusability
chrisk314 a4a2035
feat: Adds `populates_fields` kwarg to Event.handler
chrisk314 297a9b3
chore: Modifies input connection logic for event covered fields
chrisk314 68d31e7
refactor: Alternate approach to track event field coverage
chrisk314 44199ee
test: Updates validation test
chrisk314 21947ce
refactor: Method attr based approach to populates_fields
chrisk314 f4466fe
test: Adds test for populates_fields
chrisk314 72e4927
refactor: Improves complexity score
chrisk314 6556160
ci: Changes max abs complexity to C for io_controller.py with many args
chrisk314 e677956
test: Adds populates_fields on existing tests
chrisk314 32634a0
fix: Passes event_field_coverage in DataWriter
chrisk314 b87b64d
chore: Removes unrequired comment
chrisk314 f92eae8
chore: Removes unrequired method
chrisk314 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is problematic.
_periodic_status_checkcould raiseEventStreamClosedErrorin the same step where new event data is received. Exitingstephere would prevent consumption of final event. I'm looking into it.