fix: ignore hidden directories during server discovery by Copilot · Pull Request #259 · plugboard-dev/plugboard

Copilot · 2026-05-17T20:38:11Z

Summary

plugboard server discover could fail when the target directory contained a hidden virtualenv such as .venv, because discovery attempted to recurse into and import files from hidden paths. This change makes discovery skip hidden directories while preserving normal module discovery.

Changes

Discovery traversal
- Keep the recursive import walk based on os.walk.
- Prune hidden directories in place via dirs[:] so discovery does not descend into .venv and similar paths.
- Simplify module name construction using Path(...).relative_to(...).with_suffix("").
Regression coverage
- Consolidate the discovery coverage into a single parametrized CLI test.
- Cover package and non-package projects both with and without hidden directories.
- Verify that visible modules are still discovered and discovery completes without raising when hidden directories are present.

Agent-Logs-Url: https://github.com/plugboard-dev/plugboard/sessions/0bdaf24d-13ed-4323-8342-0f9fe1e414ab Co-authored-by: toby-coleman <13170610+toby-coleman@users.noreply.github.com>

toby-coleman · 2026-05-17T20:59:32Z

        assert process_route.called


+def test_cli_server_discover_ignores_hidden_directories(tmp_path: Path) -> None:


Parametrize the existing test to avoid duplication

Updated in fe09f85 by folding the duplicated coverage into the existing discovery test as a parametrized set of cases.

Agent-Logs-Url: https://github.com/plugboard-dev/plugboard/sessions/95e9b248-3b2e-44b6-8916-b2c37aa87c09 Co-authored-by: toby-coleman <13170610+toby-coleman@users.noreply.github.com>

toby-coleman · 2026-05-17T21:11:44Z

-                except (ModuleNotFoundError, ImportError, SyntaxError) as e:
-                    logger.warning(f"Failed to import module {module_name}: {e}")
+
+    def _walk(current_path: Path) -> None:


Actually keep the inplace update to dirs as it is less code @copilot

Updated in 58f2032 to restore the os.walk + dirs[:] pruning approach, while keeping the module-name handling a bit cleaner with Path.relative_to(...).with_suffix("").

Agent-Logs-Url: https://github.com/plugboard-dev/plugboard/sessions/2d8dca45-18df-4778-8cbe-25c9bccbf641 Co-authored-by: toby-coleman <13170610+toby-coleman@users.noreply.github.com>

github-actions · 2026-05-17T21:19:21Z

Benchmark comparison for 97996e58 (base) vs 58f20321 (PR)


------------------------------------------------------------------------------------------------------------------ benchmark: 2 tests -----------------------------------------------------------------------------------------------------------------
Name (time in ms)                                                                         Min                 Max                Mean            StdDev              Median               IQR            Outliers     OPS            Rounds  Iterations
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
test_benchmark_process_run (pr/.benchmarks/Linux-CPython-3.14-64bit/0001_pr)         420.9185 (1.0)      423.7608 (1.0)      422.0182 (1.0)      1.1293 (1.0)      421.4850 (1.0)      1.5078 (1.0)           1;0  2.3696 (1.0)           5           1
test_benchmark_process_run (main/.benchmarks/Linux-CPython-3.14-64bit/0001_base)     422.6454 (1.00)     434.5691 (1.03)     426.7634 (1.01)     4.7228 (4.18)     425.5294 (1.01)     5.7463 (3.81)          1;0  2.3432 (0.99)          5           1
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

Legend:
  Outliers: 1 Standard Deviation from Mean; 1.5 IQR (InterQuartile Range) from 1st Quartile and 3rd Quartile.
  OPS: Operations Per Second, computed as 1 / Mean

codecov · 2026-05-17T21:25:11Z

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

github-actions · 2026-05-23T12:57:40Z

Benchmark comparison for 7a6f8dcc (base) vs caec63b3 (PR)


------------------------------------------------------------------------------------------------------------------ benchmark: 2 tests -----------------------------------------------------------------------------------------------------------------
Name (time in ms)                                                                         Min                 Max                Mean            StdDev              Median               IQR            Outliers     OPS            Rounds  Iterations
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
test_benchmark_process_run (pr/.benchmarks/Linux-CPython-3.14-64bit/0001_pr)         519.2073 (1.0)      527.4996 (1.0)      523.3900 (1.0)      3.1511 (1.0)      523.2350 (1.0)      4.5110 (1.0)           2;0  1.9106 (1.0)           5           1
test_benchmark_process_run (main/.benchmarks/Linux-CPython-3.14-64bit/0001_base)     523.7548 (1.01)     536.5726 (1.02)     529.2097 (1.01)     5.4315 (1.72)     529.6245 (1.01)     9.1257 (2.02)          2;0  1.8896 (0.99)          5           1
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

Legend:
  Outliers: 1 Standard Deviation from Mean; 1.5 IQR (InterQuartile Range) from 1st Quartile and 3rd Quartile.
  OPS: Operations Per Second, computed as 1 / Mean

Initial plan

aa10ca1

Copilot AI assigned Copilot and toby-coleman May 17, 2026

Copilot started work on behalf of toby-coleman May 17, 2026 20:38 View session

Copilot AI linked an issue May 17, 2026 that may be closed by this pull request

bug: plugboard server discovery command fails if venv is present #258

Open

Copilot AI and others added 3 commits May 17, 2026 20:41

fix: ignore hidden directories during server discovery

f879d8d

Agent-Logs-Url: https://github.com/plugboard-dev/plugboard/sessions/0bdaf24d-13ed-4323-8342-0f9fe1e414ab Co-authored-by: toby-coleman <13170610+toby-coleman@users.noreply.github.com>

test: strengthen hidden-directory discovery coverage

f98c190

Agent-Logs-Url: https://github.com/plugboard-dev/plugboard/sessions/0bdaf24d-13ed-4323-8342-0f9fe1e414ab Co-authored-by: toby-coleman <13170610+toby-coleman@users.noreply.github.com>

test: clarify hidden-directory discovery regression

ca90bfd

Agent-Logs-Url: https://github.com/plugboard-dev/plugboard/sessions/0bdaf24d-13ed-4323-8342-0f9fe1e414ab Co-authored-by: toby-coleman <13170610+toby-coleman@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Fix discovery command failure when .venv folder is present~~ fix: ignore hidden directories during server discovery May 17, 2026

Copilot finished work on behalf of toby-coleman May 17, 2026 20:44

Copilot AI requested a review from toby-coleman May 17, 2026 20:44

toby-coleman requested changes May 17, 2026

View reviewed changes

Copilot started work on behalf of toby-coleman May 17, 2026 20:59 View session

Copilot AI and others added 2 commits May 17, 2026 21:02

refactor: simplify discovery traversal and tests

e749206

Agent-Logs-Url: https://github.com/plugboard-dev/plugboard/sessions/95e9b248-3b2e-44b6-8916-b2c37aa87c09 Co-authored-by: toby-coleman <13170610+toby-coleman@users.noreply.github.com>

test: broaden discovery parametrization

fe09f85

Agent-Logs-Url: https://github.com/plugboard-dev/plugboard/sessions/95e9b248-3b2e-44b6-8916-b2c37aa87c09 Co-authored-by: toby-coleman <13170610+toby-coleman@users.noreply.github.com>

Copilot finished work on behalf of toby-coleman May 17, 2026 21:04

Copilot AI requested a review from toby-coleman May 17, 2026 21:04

toby-coleman reviewed May 17, 2026

View reviewed changes

Copilot started work on behalf of toby-coleman May 17, 2026 21:11 View session

Copilot AI and others added 2 commits May 17, 2026 21:13

refactor: restore os.walk directory pruning

372dba6

Agent-Logs-Url: https://github.com/plugboard-dev/plugboard/sessions/2d8dca45-18df-4778-8cbe-25c9bccbf641 Co-authored-by: toby-coleman <13170610+toby-coleman@users.noreply.github.com>

refactor: simplify os.walk module path handling

58f2032

Agent-Logs-Url: https://github.com/plugboard-dev/plugboard/sessions/2d8dca45-18df-4778-8cbe-25c9bccbf641 Co-authored-by: toby-coleman <13170610+toby-coleman@users.noreply.github.com>

Copilot finished work on behalf of toby-coleman May 17, 2026 21:15

Copilot AI requested a review from toby-coleman May 17, 2026 21:15

toby-coleman marked this pull request as ready for review May 17, 2026 21:18

Merge branch 'main' into copilot/fix-discovery-command-venv-issue

caec63b

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: ignore hidden directories during server discovery#259

fix: ignore hidden directories during server discovery#259
Copilot wants to merge 9 commits into
mainfrom
copilot/fix-discovery-command-venv-issue

Copilot AI commented May 17, 2026 •

edited

Loading

Uh oh!

Uh oh!

toby-coleman May 17, 2026

Uh oh!

Copilot AI May 17, 2026

Uh oh!

toby-coleman May 17, 2026

Uh oh!

Copilot AI May 17, 2026

Uh oh!

github-actions Bot commented May 17, 2026

Uh oh!

codecov Bot commented May 17, 2026

Uh oh!

github-actions Bot commented May 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		assert process_route.called


		def test_cli_server_discover_ignores_hidden_directories(tmp_path: Path) -> None:

Conversation

Copilot AI commented May 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Changes

Uh oh!

Uh oh!

toby-coleman May 17, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI May 17, 2026

Choose a reason for hiding this comment

Uh oh!

toby-coleman May 17, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI May 17, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented May 17, 2026

Uh oh!

codecov Bot commented May 17, 2026

Codecov Report

Uh oh!

github-actions Bot commented May 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Copilot AI commented May 17, 2026 •

edited

Loading