Skip to content

fix docker image issues#462

Merged
jsladerman merged 1 commit into
mainfrom
jake/prod-3579-fix-flashing-ui-on-docs-site-docker-image
Jun 2, 2025
Merged

fix docker image issues#462
jsladerman merged 1 commit into
mainfrom
jake/prod-3579-fix-flashing-ui-on-docs-site-docker-image

Conversation

@jsladerman

Copy link
Copy Markdown
Collaborator

fixes two issues with the new dockerized version of the docs site:

  • flashing and scroll resets on every nav, this was due to Next i18n not resolving routes correctly and causing every nav to be server-side instead of client-side where possible. this could likely be fixed with some additional refactoring and configurations, but it would add more complexity than necessary given that we don't actually use it at all. removing seems to fix the problem
  • OpenGraph wasn't resolving, needed to add the NEXT_PUBLIC_ROOT_URL build arg

@jsladerman
jsladerman requested a review from a team as a code owner June 2, 2025 19:16
@jsladerman jsladerman added the bug-fixes For fixes to site code label Jun 2, 2025
@linear

linear Bot commented Jun 2, 2025

Copy link
Copy Markdown

@netlify

netlify Bot commented Jun 2, 2025

Copy link
Copy Markdown

Deploy Preview for pluraldocs ready!

Name Link
🔨 Latest commit d5898f1
🔍 Latest deploy log https://app.netlify.com/projects/pluraldocs/deploys/683df87818567a0008244ce5
😎 Deploy Preview https://deploy-preview-462--pluraldocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@jsladerman jsladerman added bug-fix and removed bug-fixes For fixes to site code labels Jun 2, 2025
@jsladerman
jsladerman merged commit 006eea4 into main Jun 2, 2025
14 of 16 checks passed
@jsladerman
jsladerman deleted the jake/prod-3579-fix-flashing-ui-on-docs-site-docker-image branch June 2, 2025 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants