Skip to content

fix: stabilize flow-test ping endpoint#201

Open
plural-copilot[bot] wants to merge 1 commit into
mainfrom
agent/fix-flow-test-ping-1747854452000
Open

fix: stabilize flow-test ping endpoint#201
plural-copilot[bot] wants to merge 1 commit into
mainfrom
agent/fix-flow-test-ping-1747854452000

Conversation

@plural-copilot
Copy link
Copy Markdown

Summary

  • remove the synthetic time-based exception from the /ping handler
  • add a focused regression test to keep /ping returning a stable 200 response
  • add pytest to project requirements for the new test

Rationale

/ping is currently implemented as deliberate demo logic that raises Exception("unknown internal error") every third second. That directly matches the observed intermittent 500s and explains the Flow 500s alert for flow-test.

This change fixes the root cause by removing the synthetic failure path, which is safer than masking the alert or changing probes while the service is expected to answer /ping successfully.

Validation

  • confirmed the intentional failure logic in app/main.py and corresponding note in README.md
  • added a regression test for repeated /ping requests
  • unable to execute tests in this environment because python3 is unavailable and Docker daemon access is denied

Plural Service: demo-prod/flow-test

Copy link
Copy Markdown
Author

@plural-copilot plural-copilot Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR was generated by the codex Plural Agent Runtime. Here's some useful information you might want to know to evaluate the ai's perfomance:

Name Details
💬 Prompt Investigate and, if safe, fix the root cause of the Flow 500s alert for service flow-test....
🔗 Run history View run history

@socket-security
Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Addedpytest@​9.0.387100100100100

View full report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant