fix: stabilize flow-test ping endpoint#201
Open
plural-copilot[bot] wants to merge 1 commit into
Open
Conversation
Author
There was a problem hiding this comment.
This PR was generated by the codex Plural Agent Runtime. Here's some useful information you might want to know to evaluate the ai's perfomance:
| Name | Details |
|---|---|
| 💬 Prompt | Investigate and, if safe, fix the root cause of the Flow 500s alert for service flow-test.... |
| 🔗 Run history | View run history |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/pinghandler/pingreturning a stable 200 responsepytestto project requirements for the new testRationale
/pingis currently implemented as deliberate demo logic that raisesException("unknown internal error")every third second. That directly matches the observed intermittent 500s and explains theFlow 500salert forflow-test.This change fixes the root cause by removing the synthetic failure path, which is safer than masking the alert or changing probes while the service is expected to answer
/pingsuccessfully.Validation
app/main.pyand corresponding note inREADME.md/pingrequestspython3is unavailable and Docker daemon access is deniedPlural Service: demo-prod/flow-test