Skip to content

Commit 5e549ff

Browse files
Fix notes generation in cli (#377)
It looks like we aren't properly collecting the values for generating notes, this should help
1 parent 1ca24e9 commit 5e549ff

1 file changed

Lines changed: 6 additions & 7 deletions

File tree

pkg/scaffold/helm.go

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -86,10 +86,6 @@ func Notes(installation *api.Installation) error {
8686

8787
repo := installation.Repository.Name
8888
ctx, _ := context.Repo(installation.Repository.Name)
89-
valuesFile := pathing.SanitizeFilepath(filepath.Join(repoRoot, repo, "helm", repo, "values.yaml"))
90-
prevVals, _ := prevValues(valuesFile)
91-
defaultValuesFile := pathing.SanitizeFilepath(filepath.Join(repoRoot, repo, "helm", repo, "default-values.yaml"))
92-
defaultPrevVals, _ := prevValues(defaultValuesFile)
9389

9490
vals := map[string]interface{}{
9591
"Values": ctx,
@@ -120,10 +116,13 @@ func Notes(installation *api.Installation) error {
120116
}
121117
}
122118

123-
for k, v := range defaultPrevVals {
124-
vals[k] = v
119+
apps := &Applications{Root: repoRoot}
120+
values, err := apps.HelmValues(repo)
121+
if err != nil {
122+
return err
125123
}
126-
for k, v := range prevVals {
124+
125+
for k, v := range values {
127126
vals[k] = v
128127
}
129128

0 commit comments

Comments
 (0)