Add Installer-EXE logic for Windows-Based targets#5
Merged
Conversation
* Install security-related registry-keys (if expressly selected for)
* HKEY_LOCAL_MACHINE\SOFTWARE\Policies\Google\Chrome\HomepageLocation
* HKEY_LOCAL_MACHINE\SOFTWARE\Policies\Google\Chrome\ManagedBookmarks
* HKEY_LOCAL_MACHINE\SOFTWARE\Policies\Google\Chrome\ManagedBookmarks
* HKEY_LOCAL_MACHINE\SOFTWARE\Policies\Google\Update\ManagedBookmarks
* Stage and nstall ADMX and ADML policy files:
* C:\Windows\PolicyDefinitions\en-US\chrome.adml
* C:\Windows\PolicyDefinitions\google.admx
* C:\Windows\PolicyDefinitions\chrome.admx
The new, stoopidly-long URLs *should* be more reliable ...At least until Google decides to "improve" things, again
...and return to original state if it changed
Attempt to resolve a conflict between how Salt likes paths and how PowerShell likes paths when running as LocalSystem
Also, allow the "Set-ItemProperty" logic to not bomb-out if a registry-key is missing/null
Use an externalized uninstallation script to provide better reliability and "chattier" output about the script's activities
Use parameters so we can try to make this more-flexible via Pillar- hosted content-specifications
using a non-iterated `names` construct isn't adequately robust and fails on Windows targets
Damn you, YAML, and your padding-sensitivity!
While we're here, update to reflect new parameter maps
ferricoxide
force-pushed
the
AddWindows_EXE
branch
5 times, most recently
from
37b49e9 to
04e20f6
Compare
ferricoxide
force-pushed
the
AddWindows_EXE
branch
from
04e20f6 to
a1e0212
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements both an installation/configuration state and a "clean" state. Both take care of:
Additionally, the "bits" are parameter-driven enough that they should provide additional flexibility beyond the explicitly tested-for usages.