[ENHANCEMENT] Add linting of PowerShell Scripts#6
Closed
ferricoxide wants to merge 42 commits into
Closed
Conversation
Also delete the installer once done
* Notepad++ and icon in context menues:
* 'HKEY_CLASSES_ROOT\*\shell\Open with Notepad++'
* 'HKEY_CLASSES_ROOT\*\shell\Open with Notepad++\command'
* Call npp on actions that would normally call the "stock" notepad
application:
* 'HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Windows NT\CurrentVersion\Image File Execution Options\notepad.exe'
* Make it so `runcmd` doesn't care if npp is in the global PATH env:
* 'HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Windows\CurrentVersion\App Paths\notepad++.exe'
* 'HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Windows\CurrentVersion\App Paths\notepad++.exe'
...and compact the version and/or url references in the config/file and package/install files to reflect relocation of fallback logic
Nest "fallback" keys under `pkg` so that * notepad_plusplus.pkg.version * notepad_plusplus.pkg.installer_uri Are the same across map-merges performed by the mapdata Jinja-logic
Especially when running from userData (EC2launch in AWS-based deployments), Windows default security-settings may interfere. Try to work around Windows' fuckery
...added because linting showed we had available testing-material that we weren't using. May as well use it to improve robustness of the script's validation-testing?
Saltstack still needs the output, but the PS linter doesn't like when the Write-Host method is used
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since this project includes some standalone PowerShell scripts, it might be a good idea to do some basic linting of them