SDT bind and removal extensions for Footnotes and Endnotes#266
Open
jaboj78 wants to merge 4 commits into
Open
Conversation
…r FootnotesPart and EndnotesPart. This makes it possible to bind values in these parts as well as remove SDT's from the parts if requested. WML parts for EndnotesPart and FootnotesPart implements ContentAccessor (again..). Docx4J now used RemoveHandler to remove SDT's from supported parts (Main, Footer, Header, Footnotes, Endnotes)
…r FootnotesPart and EndnotesPart. This makes it possible to bind values in these parts as well as remove SDT's from the parts if requested. WML parts for EndnotesPart and FootnotesPart implements ContentAccessor (again..). Docx4J now used RemoveHandler to remove SDT's from supported parts (Main, Footer, Header, Footnotes, Endnotes)
plutext
reviewed
Oct 6, 2017
| * Convenience method to getJaxbElement().getEndnote() | ||
| * @since 2.8.1 | ||
| */ | ||
| public List<Object> getContent() { |
Owner
There was a problem hiding this comment.
By the look of it, this won't work properly. getContent().add(foo) doesn't add foo to the endnote object
Author
There was a problem hiding this comment.
I've tried to let FootnotePart and EndnotePart implement the same ContentAccessor as FooterPart and HeaderPart, to handle each part in a similar way. In some previous version, the getContent() method has been un-commented. Is it possible to let FootnotePart and EnddnotePart implement ContentAccessor in a proper way?
If it's not possible to let FootnotePart and EndnotePart implement ContentAccessor, this particullar change can be reverted. The most important part, is the ability to update content controls bindings in these parts.
…art now implements ContentAccessor in a proper way. All this to support OpenDope processing of SDTs in Footnotes and Endnotes part
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HI,
I hope this pull request is created properly.
I've added some extension to Docx4J SDT binding- and removal- handlers, to support FootnotesPart and EndnotesPart. This makes it possible to bind values in these parts as well as remove SDT's from these parts, if requested in the bind-flags. WML parts for EndnotesPart and FootnotesPart implements ContentAccessor (again..). Docx4J now uses RemoveHandler to remove SDT's from supported parts (Main, Footer, Header, Footnotes, Endnotes)
I hope you'll incorporate these changes in a futurer build, or make a similar extension. I need this extension, to be able to use SDT's in footnotes and endnotes.
Thanks a lot.