fix: Fail on ecrecover failure (#3)

pmerkleplant · web-flow · commit 35d4c4b6d798 · 2025-07-03T13:24:12.000+05:30
diff --git a/src/Verifier.sol b/src/Verifier.sol
@@ -77,7 +77,7 @@ contract Verifier is Ownable {
         // v is 27 or 28 based on the y-value being even or odd
         // verify the signature
         address recoveredSigner = ecrecover(digest, v, r, s);
-        if (recoveredSigner != signer) {
+        if (recoveredSigner == address(0) || recoveredSigner != signer) {
             revert InvalidSignature();
         }
 

Original file line number	Diff line number	Diff line change
`@@ -77,7 +77,7 @@ contract Verifier is Ownable {`
`77`	`77`	`// v is 27 or 28 based on the y-value being even or odd`
`78`	`78`	`// verify the signature`
`79`	`79`	`address recoveredSigner = ecrecover(digest, v, r, s);`
`80`		`- if (recoveredSigner != signer) {`
	`80`	`+ if (recoveredSigner == address(0) \|\| recoveredSigner != signer) {`
`81`	`81`	`revert InvalidSignature();`
`82`	`82`	`}`
`83`	`83`