Skip to content

Commit 00edb5b

Browse files
pmbrullclaude
andcommitted
feat(config): move embedding config to llmConfiguration.embeddings; slim naturalLanguageSearch
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
1 parent 3d9edf6 commit 00edb5b

1 file changed

Lines changed: 18 additions & 26 deletions

File tree

conf/openmetadata.yaml

Lines changed: 18 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -590,33 +590,8 @@ elasticsearch:
590590
naturalLanguageSearch:
591591
enabled: ${NATURAL_LANGUAGE_SEARCH_ENABLED:-false}
592592
semanticSearchEnabled: ${SEMANTIC_SEARCH_ENABLED:-false}
593-
embeddingProvider: ${EMBEDDING_PROVIDER:-bedrock} # Options: "openai", "bedrock", "google", "djl"
594-
maxConcurrentRequests: ${MAX_CONCURRENT_EMBEDDING_REQUESTS:-10}
595593
providerClass: ${NATURAL_LANGUAGE_SEARCH_PROVIDER_CLASS:-org.openmetadata.service.search.nlq.NoOpNLQService}
596-
bedrock:
597-
awsConfig:
598-
enabled: ${BEDROCK_AWS_IAM_AUTH_ENABLED:-false}
599-
region: ${AWS_BEDROCK_REGION:-""}
600-
accessKeyId: ${AWS_BEDROCK_ACCESS_KEY:-""}
601-
secretAccessKey: ${AWS_BEDROCK_SECRET_KEY:-""}
602-
sessionToken: ${AWS_BEDROCK_SESSION_TOKEN:-""}
603-
embeddingModelId: ${AWS_BEDROCK_EMBED_MODEL_ID:-""}
604-
embeddingDimension: ${AWS_BEDROCK_EMBEDDING_DIMENSION:-""}
605-
openai:
606-
apiKey: ${OPENAI_API_KEY:-""}
607-
# For Azure OpenAI, set endpoint and deploymentName:
608-
endpoint: ${OPENAI_API_ENDPOINT:-""} # e.g., https://your-resource.openai.azure.com
609-
deploymentName: ${OPENAI_DEPLOYMENT_NAME:-""} # Required for Azure OpenAI
610-
apiVersion: ${OPENAI_API_VERSION:-"2024-02-01"} # Azure OpenAI API version
611-
embeddingModelId: ${OPENAI_EMBEDDING_MODEL_ID:-"text-embedding-3-small"}
612-
embeddingDimension: ${OPENAI_EMBEDDING_DIMENSION:-1536}
613-
google:
614-
apiKey: ${GOOGLE_API_KEY:-""} # API key from Google AI Studio
615-
embeddingModelId: ${GOOGLE_EMBEDDING_MODEL_ID:-"gemini-embedding-001"}
616-
embeddingDimension: ${GOOGLE_EMBEDDING_DIMENSION:-768} # Sent as outputDimensionality. gemini-embedding-001 supports 768/1536/3072; text-embedding-004 supports 768.
617-
endpoint: ${GOOGLE_API_ENDPOINT:-""} # Optional override; full :embedContent URL. Leave empty to use the default Generative Language API endpoint.
618-
djl:
619-
embeddingModel: ${DJL_EMBEDDING_MODEL:-"ai.djl.huggingface.pytorch/sentence-transformers/all-MiniLM-L6-v2"}
594+
# Embedding provider/model/credentials now live under llmConfiguration.embeddings (single LLM config home).
620595

621596
# Platform-wide LLM provider configuration. Generic - consumed by any feature that needs LLM
622597
# completions (e.g. Context Center knowledge-pill extraction and the MCP Chat application). The
@@ -651,6 +626,23 @@ llmConfiguration:
651626
modelId: ${LLM_ANTHROPIC_MODEL_ID:-"claude-3-5-sonnet-20240620"}
652627
baseUrl: ${LLM_ANTHROPIC_BASE_URL:-"https://api.anthropic.com"}
653628
maxTokens: ${LLM_ANTHROPIC_MAX_TOKENS:-4096}
629+
# Vector embeddings for semantic search. Credentials reuse the provider blocks above
630+
# (bedrock.awsConfig, openai.apiKey/endpoint, google.apiKey); this section only selects the
631+
# embedding provider + model. The embedding provider may differ from the chat provider above.
632+
embeddings:
633+
provider: ${EMBEDDING_PROVIDER:-bedrock} # bedrock | openai | google | djl
634+
maxConcurrentRequests: ${MAX_CONCURRENT_EMBEDDING_REQUESTS:-10}
635+
bedrock:
636+
embeddingModelId: ${AWS_BEDROCK_EMBED_MODEL_ID:-"amazon.titan-embed-text-v2:0"}
637+
embeddingDimension: ${AWS_BEDROCK_EMBEDDING_DIMENSION:-512}
638+
openai:
639+
embeddingModelId: ${OPENAI_EMBEDDING_MODEL_ID:-"text-embedding-3-small"}
640+
embeddingDimension: ${OPENAI_EMBEDDING_DIMENSION:-1536}
641+
google:
642+
embeddingModelId: ${GOOGLE_EMBEDDING_MODEL_ID:-"gemini-embedding-001"}
643+
embeddingDimension: ${GOOGLE_EMBEDDING_DIMENSION:-768}
644+
djl:
645+
embeddingModel: ${DJL_EMBEDDING_MODEL:-"ai.djl.huggingface.pytorch/sentence-transformers/all-MiniLM-L6-v2"}
654646

655647
eventMonitoringConfiguration:
656648
eventMonitor: ${EVENT_MONITOR:-prometheus} # Possible values are "prometheus", "cloudwatch"

0 commit comments

Comments
 (0)