Security: Potential DOM XSS via unsanitized stack frame rendering#968
Open
tuanaiseo wants to merge 2 commits intopmmmwh:mainfrom
Open
Conversation
Runtime error overlay renders `functionName` and `fileName` into the DOM using `innerHTML`. Stack frame fields can be attacker-influenced in some browser/runtime scenarios (e.g., crafted error messages/source URLs), which may allow script/HTML injection in the developer browser session. Affected files: RuntimeErrorStack.js, CompileErrorTrace.js Signed-off-by: tuanaiseo <221258316+tuanaiseo@users.noreply.github.com>
Runtime error overlay renders `functionName` and `fileName` into the DOM using `innerHTML`. Stack frame fields can be attacker-influenced in some browser/runtime scenarios (e.g., crafted error messages/source URLs), which may allow script/HTML injection in the developer browser session. Affected files: RuntimeErrorStack.js, CompileErrorTrace.js Signed-off-by: tuanaiseo <221258316+tuanaiseo@users.noreply.github.com>
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Runtime error overlay renders
functionNameandfileNameinto the DOM usinginnerHTML. Stack frame fields can be attacker-influenced in some browser/runtime scenarios (e.g., crafted error messages/source URLs), which may allow script/HTML injection in the developer browser session.Severity:
mediumFile:
overlay/components/RuntimeErrorStack.jsSolution
Avoid
innerHTMLfor dynamic values. UsetextContentand build spacing/layout with separate text nodes or CSS. If HTML is required, sanitize with a strict allowlist sanitizer before insertion.Changes
overlay/components/RuntimeErrorStack.js(modified)overlay/components/CompileErrorTrace.js(modified)Testing