Security: Overlay compile trace uses HTML insertion on transformed error content#969
Open
tuanaiseo wants to merge 1 commit intopmmmwh:mainfrom
Conversation
Compile error entries are inserted with `elem.innerHTML = entry.content`. Although the code encodes input first, safety depends on third-party transformation behavior (`anser` + `html-entities`) and future changes. A malformed or unexpected transformation path could reintroduce executable HTML. Affected files: CompileErrorTrace.js Signed-off-by: tuanaiseo <221258316+tuanaiseo@users.noreply.github.com>
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Compile error entries are inserted with
elem.innerHTML = entry.content. Although the code encodes input first, safety depends on third-party transformation behavior (anser+html-entities) and future changes. A malformed or unexpected transformation path could reintroduce executable HTML.Severity:
lowFile:
overlay/components/CompileErrorTrace.jsSolution
Prefer
textContentrendering for message fragments, or sanitizeentry.contentwith a strict sanitizer before assigning toinnerHTML.Changes
overlay/components/CompileErrorTrace.js(modified)Testing