Move syncDefaultBufferType to Pass

Author: vanruesc

src/core/Pass.ts

@@ -148,6 +148,12 @@ export abstract class Pass<TMaterial extends Material | null = null>
 
 	private _attached: boolean;
 
+	/**
+	 * @see {@link autoSyncDefaultBuffers}
+	 */
+
+	private _autoSyncDefaultBuffers: boolean;
+
 	/**
 	 * @see {@link timer}
 	 */
@@ -251,6 +257,7 @@ export abstract class Pass<TMaterial extends Material | null = null>
 		this._name = name;
 		this._enabled = true;
 		this._attached = false;
+		this._autoSyncDefaultBuffers = true;
 		this._renderer = null;
 		this._timer = null;
 		this._scene = null;
@@ -339,6 +346,29 @@ export abstract class Pass<TMaterial extends Material | null = null>
 
 	}
 
+	/**
+	 * Controls whether the settings of the input and output default buffers should be synchronized.
+	 *
+	 * @defaultValue true
+	 */
+
+	protected get autoSyncDefaultBuffers(): boolean {
+
+		return this._autoSyncDefaultBuffers;
+
+	}
+
+	protected set autoSyncDefaultBuffers(value: boolean) {
+
+		if(this._autoSyncDefaultBuffers !== value) {
+
+			this._autoSyncDefaultBuffers = value;
+			this.syncDefaultBuffers();
+
+		}
+
+	}
+
 	/**
 	 * A list of subpasses.
 	 *
@@ -729,6 +759,59 @@ export abstract class Pass<TMaterial extends Material | null = null>
 
 	}
 
+	/**
+	 * Synchronizes the texture settings of the input and output default buffers.
+	 *
+	 * This method ensures that the output buffer uses adequate settings for storing values from the input buffer.
+	 */
+
+	private syncDefaultBuffers(): void {
+
+		const renderer = this.renderer;
+		const inputBuffer = this.input.defaultBuffer?.value ?? null;
+		const outputBuffer = this.output.defaultBuffer?.value ?? null;
+
+		if(!this.autoSyncDefaultBuffers || renderer === null || inputBuffer === null || outputBuffer === null) {
+
+			return;
+
+		}
+
+		const texture = outputBuffer.texture;
+
+		texture.needsUpdate = (
+			texture.format !== inputBuffer.format ||
+			texture.internalFormat !== inputBuffer.internalFormat ||
+			texture.type !== inputBuffer.type
+		);
+
+		if(texture.needsUpdate) {
+
+			texture.format = inputBuffer.format;
+			texture.internalFormat = inputBuffer.internalFormat;
+			texture.type = inputBuffer.type;
+
+		}
+
+		// If the output buffer uses low precision, enable sRGB encoding to reduce information loss.
+		const useSRGBFramebuffer = !this.output.frameBufferPrecisionHigh && renderer.outputColorSpace === SRGBColorSpace;
+
+		if(useSRGBFramebuffer && texture.colorSpace !== SRGBColorSpace) {
+
+			texture.colorSpace = SRGBColorSpace;
+			texture.needsUpdate = true;
+
+		}
+
+		if(texture.needsUpdate) {
+
+			// Notify listeners.
+			this.output.defaultBuffer!.texture.setChanged();
+
+		}
+
+	}
+
 	/**
 	 * Checks if this pass uses convolution shaders.
 	 *
@@ -1133,6 +1216,7 @@ export abstract class Pass<TMaterial extends Material | null = null>
 
 			case "change":
 				this.updateFullscreenMaterialsInput();
+				this.syncDefaultBuffers();
 				this.onInputChange();
 				break;
 
@@ -1159,6 +1243,7 @@ export abstract class Pass<TMaterial extends Material | null = null>
 			case "change":
 				this.updateOutputBufferSize();
 				this.updateFullscreenMaterialsOutput();
+				this.syncDefaultBuffers();
 				this.onOutputChange();
 				break;
 

src/core/io/IOManager.ts

@@ -1,4 +1,4 @@
-import { Material, SRGBColorSpace, WebGLRenderTarget } from "three";
+import { Material, WebGLRenderTarget } from "three";
 import { GBuffer } from "../../enums/GBuffer.js";
 import { ClearPass } from "../../passes/ClearPass.js";
 import { GeometryPass } from "../../passes/GeometryPass.js";
@@ -247,8 +247,6 @@ export class IOManager {
 		this.updateOutput(pipeline);
 		this.updateInput(pipeline);
 
-		IOManager.syncDefaultBufferType(pipeline);
-
 	}
 
 	/**
@@ -276,44 +274,6 @@ export class IOManager {
 
 	}
 
-	/**
-	 * Synchronizes the texture type of input/output default buffers.
-	 *
-	 * @param pipeline - The pipeline to update.
-	 */
-
-	private static syncDefaultBufferType(pipeline: RenderPipeline): void {
-
-		for(const pass of pipeline.passes.filter(x => x.enabled)) {
-
-			const inputBuffer = pass.input.defaultBuffer?.value ?? null;
-			const outputBuffer = pass.output.defaultBuffer?.value ?? null;
-
-			if(inputBuffer === null || outputBuffer === null || pass instanceof GeometryPass) {
-
-				continue;
-
-			}
-
-			outputBuffer.texture.format = inputBuffer.format;
-			outputBuffer.texture.internalFormat = inputBuffer.internalFormat;
-			outputBuffer.texture.type = inputBuffer.type;
-			outputBuffer.texture.needsUpdate = true;
-
-			if(!pass.input.frameBufferPrecisionHigh && pipeline.renderer?.outputColorSpace === SRGBColorSpace) {
-
-				// If the output buffer uses low precision, enable sRGB encoding to reduce information loss.
-				outputBuffer.texture.colorSpace = SRGBColorSpace;
-
-			}
-
-			// Notify listeners that this texture has changed.
-			pass.output.defaultBuffer!.texture.setChanged();
-
-		}
-
-	}
-
 	/**
 	 * Returns the main geometry pass of the given pipeline.
 	 *