clean up

Author: v1rtl

src/effects/Bloom.tsx

@@ -1,7 +1,6 @@
 import { BloomEffect, BlendFunction } from 'postprocessing'
-import type { BloomEffectOptions } from 'postprocessing'
 import { wrapEffect } from '../util'
 
-export const Bloom = wrapEffect<typeof BloomEffect, BloomEffectOptions>(BloomEffect, {
+export const Bloom = wrapEffect(BloomEffect, {
   blendFunction: BlendFunction.ADD,
 })

src/effects/ScanlineEffect.tsx

@@ -1,4 +1,4 @@
 import { ScanlineEffect, BlendFunction } from 'postprocessing'
 import { wrapEffect } from '../util'
 
-export const Scanline = wrapEffect(ScanlineEffect, { blendFunction: BlendFunction.OVERLAY })
+export const Scanline = wrapEffect(ScanlineEffect, { blendFunction: BlendFunction.OVERLAY, density: 1.25 })

src/effects/SelectiveBloom.tsx

@@ -91,7 +91,6 @@ export const SelectiveBloom = forwardRef(function SelectiveBloom(
     }
   }, [effect, invalidate, lights, selectionLayer])
 
-  const ref = useRef<SelectiveBloomEffect>()
   useEffect(() => {
     if (api && api.enabled) {
       if (api.selected?.length) {

src/util.tsx

@@ -21,7 +21,10 @@ export type EffectProps<T extends EffectConstructor> = ReactThreeFiber.Node<
 let i = 0
 const components = new WeakMap<EffectConstructor, React.ExoticComponent<any> | string>()
 
-export const wrapEffect = <T extends EffectConstructor, P extends EffectProps<T>>(effect: T, defaults?: P) =>
+export const wrapEffect = <T extends EffectConstructor, P extends EffectProps<T> = EffectProps<T>>(
+  effect: T,
+  defaults?: P
+) =>
   /* @__PURE__ */ React.forwardRef<T, P>(function Effect(
     { blendFunction = defaults?.blendFunction, opacity = defaults?.opacity, ...props },
     ref