docs(core): clarify null/undefined goals are skipped, not animated#2528
Merged
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Docs preview: https://pr-2528---react-spring-204644970562.europe-west1.run.app Deployed at |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documents the long-standing contract that
null/undefined(andfalse) in a spring goal mean "leave this value alone" rather than a target to animate towards — a spring cannot animate tonull. This surfaces in #2295, where the silent skip is mistaken for a bug.The note is added to the existing "Any type is valid…" paragraph on the SpringValue page, which is where the animatable-types behaviour is already described.
Why
GoalValues<T>allows| null), but undocumented for users.nullis meaningless — there is nothing to interpolate to — sonullis reserved for partial updates that leave a key untouched.Related issues