fix(shared): guard string interpolator against number-less output values#2529
Merged
Conversation
A value with no numbers (e.g. boxShadow: 'none' or an unresolved CSS variable that falls through as its literal var(--x) text) made String.match return null, and the non-null assertion let .map run on it, throwing 'Cannot read properties of null'. Extract numeric tokens through a null-safe helper so such values interpolate gracefully. Closes #2327
🦋 Changeset detectedLatest commit: 64a1399 The changes in this PR will be included in the next version bump. This PR includes changesets to release 12 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Animating a string prop whose output includes a value with no numbers — most commonly
boxShadow: 'none', or an unresolved CSS variable that falls through as its literalvar(--x)text — crashed at runtime with the crypticTypeError: Cannot read properties of null (reading 'map'). The string interpolator extracts numeric tokens withString.match(numberRegex), which returnsnullfor such strings, and a non-null assertion (!) let.maprun onnull.This routes the three token extractions through a null-safe helper, so a number-less value yields no tokens and degrades gracefully instead of throwing. Inputs that already worked are unaffected — the assertion was compile-time only, so the fallback path is reachable solely where the code used to crash.
Closes #2327.
Behaviour
['none', '0px 4px 8px rgba(0, 0, 0, 0.5)']no longer throws; in-between frames return'none'.