feat(eslint-plugin): add no-fast-state rule#3699
Closed
travisbreaks wants to merge 1 commit into
Closed
Conversation
Warns when React useState/useReducer setters are called inside useFrame callbacks. This is a performance anti-pattern: state setters trigger full React re-renders every frame (60fps = 60 re-renders/second). The correct pattern is useRef with direct mutation. - Tracks useState and useReducer destructured setter names - Flags any call to a known setter inside a useFrame callback - Registered in both recommended and all configs via codegen - Comprehensive tests (5 valid, 6 invalid cases), 100% coverage - Docs following existing rule pattern Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 4559999:
|
Author
|
Friendly ping. Happy to iterate on this if needed. |
Author
|
Closing due to no review activity. Happy to reopen if there's interest. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
no-fast-staterule that warns whenuseState/useReducersetters are called insideuseFramecallbacksuseRefwith direct mutation insideuseFrameCompanion to
prefer-useloader(#3698), covering another rule from the ESLint plugin RFC (#2701).Implementation
useStateanduseReducerdestructured setter namesuseFramecallback scopeuseFramerecommendedandallconfigs via codegenTest plan
Example