refactor: improve error handling and resource cleanup in file operations

Author: pmoscode

config/formats/formats.go

@@ -23,8 +23,7 @@ func parseConfig(filename string, out any, parser Parser) error {
 func loadConfigFile(filename string) ([]byte, error) {
 	configFile, err := os.ReadFile(filepath.Clean(filename))
 	if err != nil {
-		//lint:ignore ST1005 this is a formatted error
-		return nil, fmt.Errorf("error reading config file: %s\n", err)
+		return nil, fmt.Errorf("reading config file: %w", err)
 	}
 
 	return configFile, nil

filesystem/filesystem_test.go

@@ -1,6 +1,7 @@
 package filesystem
 
 import (
+	"log"
 	"os"
 	"testing"
 
@@ -10,7 +11,12 @@ import (
 
 func TestFileExists(t *testing.T) {
 	file := createTempFile(t)
-	defer os.Remove(file)
+	defer func(name string) {
+		err := os.Remove(name)
+		if err != nil {
+			log.Printf("could not remove temp file: %s, error: %v", name, err)
+		}
+	}(file)
 
 	assert.True(t, FileExists(file), "expected file to exist: %s", file)
 }
@@ -25,7 +31,12 @@ func createTempFile(t *testing.T) string {
 	t.Helper()
 	f, err := os.CreateTemp("./", "temp-*.txt")
 	require.NoError(t, err, "could not create temp file")
-	defer f.Close()
+	defer func(f *os.File) {
+		err = f.Close()
+		if err != nil {
+			log.Printf("could not close temp file: %s, error: %v", f.Name(), err)
+		}
+	}(f)
 
 	return f.Name()
 }

shutdown/shutdown.go

@@ -38,7 +38,7 @@ func (o *observerSingle) AddCommand(fn ObserverFunc) {
 // Will be automatically executed on first call to GetObserver.
 func (o *observerSingle) hookOnSigTerm() {
 	channel := make(chan os.Signal, 1)
-	//lint:ignore SA1017 Kill code 15 should always lead to the final execution of provided functions
+	//nolint:govet // SA1017: intentional – SIGTERM must always trigger graceful shutdown hooks
 	signal.Notify(channel, os.Interrupt, syscall.SIGTERM)
 	go func() {
 		<-channel