test: add additional unit tests for all modules

Author: pmoscode

config/config_test.go

@@ -1,6 +1,8 @@
 package config
 
 import (
+	"os"
+	"path/filepath"
 	"testing"
 
 	"github.com/stretchr/testify/assert"
@@ -84,3 +86,124 @@ func TestResolveTagsComplex(t *testing.T) {
 	assert.Len(t, testData.GmdDataMap1, 3)
 	assert.Len(t, testData.GmdDataMap2, 4)
 }
+
+func TestLoadFromEnvironmentNonPointer(t *testing.T) {
+	type Cfg struct {
+		Val string `env:"name=X"`
+	}
+	err := LoadFromEnvironment(Cfg{})
+	require.Error(t, err)
+	assert.Contains(t, err.Error(), "pointer")
+}
+
+func TestLoadFromEnvironmentBoolField(t *testing.T) {
+	type Cfg struct {
+		Flag bool `env:"name=BOOL_CFG"`
+	}
+	t.Setenv("BOOL_CFG", "true")
+
+	var cfg Cfg
+	err := LoadFromEnvironment(&cfg)
+	require.NoError(t, err)
+	assert.True(t, cfg.Flag)
+}
+
+type unexportedFieldConfig struct {
+	Public  string `env:"name=PUB_VAL"`
+	private string `env:"name=PRIV_VAL"` //nolint:unused // test for unexported field handling
+}
+
+func TestLoadFromEnvironmentUnexportedField(t *testing.T) {
+	t.Setenv("PUB_VAL", "public")
+	t.Setenv("PRIV_VAL", "private")
+
+	cfg := unexportedFieldConfig{}
+	err := LoadFromEnvironment(&cfg)
+	require.NoError(t, err)
+	assert.Equal(t, "public", cfg.Public)
+	// private field should not be set (unexported)
+}
+
+func TestLoadFromEnvironmentNoTags(t *testing.T) {
+	type Cfg struct {
+		Value string
+	}
+	cfg := Cfg{Value: "original"}
+	err := LoadFromEnvironment(&cfg)
+	require.NoError(t, err)
+	assert.Equal(t, "original", cfg.Value, "fields without env tag should not be modified")
+}
+
+func TestLoadFromFileYaml(t *testing.T) {
+	type FileCfg struct {
+		Host string `yaml:"host" env:"name=YAML_FILE_HOST"`
+		Port int    `yaml:"port" env:"name=YAML_FILE_PORT"`
+	}
+	content := `
+host: filehost
+port: 3000
+`
+	path := createTempConfigFile(t, "config.yaml", content)
+
+	// Set env vars to match file values so LoadFromEnvironment doesn't overwrite
+	t.Setenv("YAML_FILE_HOST", "filehost")
+	t.Setenv("YAML_FILE_PORT", "3000")
+
+	var cfg FileCfg
+	err := LoadFromFile(path, &cfg, YAML)
+	require.NoError(t, err)
+	assert.Equal(t, "filehost", cfg.Host)
+	assert.Equal(t, 3000, cfg.Port)
+}
+
+func TestLoadFromFileJson(t *testing.T) {
+	type FileCfg struct {
+		Host string `json:"host" env:"name=JSON_FILE_HOST"`
+		Port int    `json:"port" env:"name=JSON_FILE_PORT"`
+	}
+	content := `{"host":"jsonhost","port":4000}`
+	path := createTempConfigFile(t, "config.json", content)
+
+	t.Setenv("JSON_FILE_HOST", "jsonhost")
+	t.Setenv("JSON_FILE_PORT", "4000")
+
+	var cfg FileCfg
+	err := LoadFromFile(path, &cfg, JSON)
+	require.NoError(t, err)
+	assert.Equal(t, "jsonhost", cfg.Host)
+	assert.Equal(t, 4000, cfg.Port)
+}
+
+func TestLoadFromFileNotFound(t *testing.T) {
+	type Cfg struct {
+		Val string `env:"name=X"`
+	}
+	var cfg Cfg
+	err := LoadFromFile("/nonexistent/config.yaml", &cfg, YAML)
+	require.Error(t, err)
+}
+
+func TestLoadFromFileEnvOverride(t *testing.T) {
+	type FileCfg struct {
+		Host string `yaml:"host" env:"name=OVERRIDE_HOST"`
+	}
+	content := `host: fromfile`
+	path := createTempConfigFile(t, "config.yaml", content)
+
+	t.Setenv("OVERRIDE_HOST", "fromenv")
+
+	var cfg FileCfg
+	err := LoadFromFile(path, &cfg, YAML)
+	require.NoError(t, err)
+	// Environment should override file value
+	assert.Equal(t, "fromenv", cfg.Host)
+}
+
+func createTempConfigFile(t *testing.T, name, content string) string {
+	t.Helper()
+	dir := t.TempDir()
+	path := filepath.Join(dir, name)
+	err := os.WriteFile(path, []byte(content), 0600)
+	require.NoError(t, err)
+	return path
+}

config/formats/formats_test.go

@@ -0,0 +1,92 @@
+package formats
+
+import (
+	"os"
+	"path/filepath"
+	"testing"
+
+	"github.com/stretchr/testify/assert"
+	"github.com/stretchr/testify/require"
+)
+
+type testConfig struct {
+	Name string `yaml:"name" json:"name"`
+	Port int    `yaml:"port" json:"port"`
+}
+
+func createTempFile(t *testing.T, filename, content string) string {
+	t.Helper()
+	dir := t.TempDir()
+	path := filepath.Join(dir, filename)
+	err := os.WriteFile(path, []byte(content), 0600)
+	require.NoError(t, err)
+	return path
+}
+
+func TestParseYamlConfig(t *testing.T) {
+	path := createTempFile(t, "config.yaml", `
+name: testapp
+port: 8080
+`)
+	var cfg testConfig
+	err := ParseYamlConfig(path, &cfg)
+	require.NoError(t, err)
+	assert.Equal(t, "testapp", cfg.Name)
+	assert.Equal(t, 8080, cfg.Port)
+}
+
+func TestParseJsonConfig(t *testing.T) {
+	path := createTempFile(t, "config.json", `{"name":"jsonapp","port":9090}`)
+
+	var cfg testConfig
+	err := ParseJsonConfig(path, &cfg)
+	require.NoError(t, err)
+	assert.Equal(t, "jsonapp", cfg.Name)
+	assert.Equal(t, 9090, cfg.Port)
+}
+
+func TestParseConfigWithCustomParser(t *testing.T) {
+	path := createTempFile(t, "config.yaml", `
+name: custom
+port: 3000
+`)
+	var cfg testConfig
+	err := ParseConfig(path, &cfg, func(in []byte, out any) error {
+		// Use yaml under the hood
+		return ParseYamlConfig(path, out)
+	})
+	// ParseConfig calls parseConfig which calls loadConfigFile and then the parser
+	// The custom parser here re-reads via ParseYamlConfig, but that's fine for testing
+	require.NoError(t, err)
+	assert.Equal(t, "custom", cfg.Name)
+}
+
+func TestParseYamlConfigFileNotFound(t *testing.T) {
+	var cfg testConfig
+	err := ParseYamlConfig("/nonexistent/path/config.yaml", &cfg)
+	require.Error(t, err)
+	assert.Contains(t, err.Error(), "reading config file")
+}
+
+func TestParseJsonConfigFileNotFound(t *testing.T) {
+	var cfg testConfig
+	err := ParseJsonConfig("/nonexistent/path/config.json", &cfg)
+	require.Error(t, err)
+	assert.Contains(t, err.Error(), "reading config file")
+}
+
+func TestParseYamlConfigInvalidContent(t *testing.T) {
+	path := createTempFile(t, "bad.yaml", `{{{invalid yaml`)
+
+	var cfg testConfig
+	err := ParseYamlConfig(path, &cfg)
+	require.Error(t, err)
+}
+
+func TestParseJsonConfigInvalidContent(t *testing.T) {
+	path := createTempFile(t, "bad.json", `{not json`)
+
+	var cfg testConfig
+	err := ParseJsonConfig(path, &cfg)
+	require.Error(t, err)
+}