Organizing and Simplifying the MidLoop (at least for the res and labor caps section)#1579
Open
The1stBurb wants to merge 18 commits into
Open
Organizing and Simplifying the MidLoop (at least for the res and labor caps section)#1579The1stBurb wants to merge 18 commits into
The1stBurb wants to merge 18 commits into
Conversation
…ns to be in a knowVal function like univercity has anyways changed a few vars to be shorter in the same code BUG: fixed biolab's knowledge cap gain on the structure popup specifically when with high_pop and frost elemental. wasn't adjusted for high pop
also organized a lot of midloop and i am going through the organized stuff and simplifying it - This includes removing repeated math calculations (like calculate the value for the cap icnrease and the breakdown seperatley) and shortened variables (like using space_home = actions.space.spc_home, then calling space_home.garage instead of actions.space.spc_home.garage multiple times)
The1stBurb
changed the title
mostly changing global.race.species to s_name (them same)
ok so i got distracted *ahem* discord people *ahem* and simplified the city and space initStruct blocks! (in warlord)
may have started bank
…ompost, soul_well, smokehouse), rock_quarry, lumber_yard, graveyard Changed *Val() funcs to be *Cap() to reflect their nature *Val() now means resource.*.amount - may be addition or just eq *Cap() now means caps['*'] *Disp() now means any value / cap that has any special math to determine display value - You may encounter a *DispC or *DispV, (cap or val) which means a buildling displays both the cap and value with special math, so it needs to handle both
adding a simple function that can do all the things for you! (in the middle of adding it)
so basically i made it so that it now uses caps:{resName(count}{return count * maths for res}} and can be smart and you only have to list each location
but it may only work for the city techs
um yea it is very smaller and works better
…ndGlob to just have vars for it also pointing out we dont need to recalc if its from action.caps
BUG -> tooltip of apartment had a 2x Money Cap if extravagant governor. This was removed.
…ng them throught the BHStorage function removing unnecesary planet action code that is run in midLoop (got to foundry)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BUG: fixed biolab's knowledge cap gain on the structure popup specifically when with genes high_pop and frost elemental. wasn't adjusted for high pop with
highPopAdjust()