Commit eb47163
fix: add cross-platform build support for Windows (replace rm/cp with cross-platform alternatives) (#1054)
* fix: add cross-platform build support for Windows
- Replace rm -rf with rimraf for cross-platform directory cleanup
- Add Node.js copy script to replace Unix cp command
- Makes build process work on Windows
* chore: update package-lock.json for rimraf dependency
- Adds rimraf to package-lock.json for reproducible installs
- Ensures npm ci works correctly
This fixes the CI failure reported in PR review.
* fix(build): use rimraf v5 for Node 18 compatibility
- Use rimraf@5.0.5 (supports Node 14+) instead of v6
- Add copy-assets.js for cross-platform file copying
- Maintains Windows compatibility while supporting Node 18
This PR now works with the project's Node 18 requirement.
* fix: replace rimraf with node stdlib clean for engine compat
rimraf@5/6 requires Node >=20 via path-scurry@2, but engines say >=18.
Replace with core/scripts/clean.js using fs.rmSync.
Also strip UTF-8 BOM from core/scripts/copy-assets.js and delete the
duplicate root-level scripts/copy-assets.js.
---------
Co-authored-by: Samuel EF. Tinnerholm <samuel.tinnerholm@gmail.com>1 parent 4eab0aa commit eb47163
4 files changed
Lines changed: 33 additions & 7 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
22 | 22 | | |
23 | 23 | | |
24 | 24 | | |
25 | | - | |
| 25 | + | |
26 | 26 | | |
27 | | - | |
| 27 | + | |
28 | 28 | | |
29 | 29 | | |
30 | 30 | | |
| |||
55 | 55 | | |
56 | 56 | | |
57 | 57 | | |
58 | | - | |
59 | 58 | | |
60 | 59 | | |
61 | 60 | | |
62 | 61 | | |
| 62 | + | |
63 | 63 | | |
64 | 64 | | |
65 | 65 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
0 commit comments